From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 460F5C10F1A for ; Thu, 9 May 2024 12:59:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD5586B0082; Thu, 9 May 2024 08:59:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5E9C6B0088; Thu, 9 May 2024 08:59:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFF916B0089; Thu, 9 May 2024 08:59:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 909116B0082 for ; Thu, 9 May 2024 08:59:15 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0DB69121366 for ; Thu, 9 May 2024 12:59:15 +0000 (UTC) X-FDA: 82098863070.24.5EA03AE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id DF25C20019 for ; Thu, 9 May 2024 12:59:12 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715259553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rmcTfwQMEV3ZG0HLZJJqxn8Rm7vbkUZ6uyKb8q10qD8=; b=bll5exxzsXJBRZA1EAKtu0Z4qTmX1Ff+eNlTZUL0op6bf9NnAj38Depp2n0s+TRNAFT+ZJ +0SCLT18ICekq57mCuYt7+NeovTiyFAXqV2SGCDDBjHGfDkd/LGIk73Quv0K8PcRvQQ0Ng UUs7/GLbb18lw4408YF+zDW6MzUYnyw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715259553; a=rsa-sha256; cv=none; b=II/Llswyajjypo1sUoPjfWplZ9M3WTpd9pqGZIph362253IudTRUFD9sWLQJr2PFOU7UhP Y4XKCD5+gPTzF76qEifYf4jfeT7aqHrJQccKuyif1uGj6tWdoD18GClddb6e2ugidubJzI +b2ClMAohNAuBFAZthJ/KAQ4q1j1jc0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 53070106F; Thu, 9 May 2024 05:59:37 -0700 (PDT) Received: from [10.1.38.172] (XHFQ2J9959.cambridge.arm.com [10.1.38.172]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2DF473F6A8; Thu, 9 May 2024 05:59:11 -0700 (PDT) Message-ID: Date: Thu, 9 May 2024 13:59:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master 10159/12060] arch/arm64/include/asm/pgtable.h:1102:16: error: implicit declaration of function 'pud_valid'; did you mean 'pmd_valid'? Content-Language: en-GB To: Will Deacon Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Catalin Marinas References: <202405082221.43rfWxz5-lkp@intel.com> <10cd4b97-d780-4524-a0ee-89f26a7897fc@arm.com> <20240508171211.GB23294@willie-the-truck> From: Ryan Roberts In-Reply-To: <20240508171211.GB23294@willie-the-truck> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DF25C20019 X-Stat-Signature: 9peaiak87mhzn49hzk5des99rqnjncut X-Rspam-User: X-HE-Tag: 1715259552-185832 X-HE-Meta: U2FsdGVkX1/Wik2zC8NSOhlsLFz6BPMeEmgZcokmyvKZozwqejPuZQmSZZEWmTEMeL8ypyxDguFqI1M9PpvYMpVEPI2niHvtvayUif5FEMJb951NkHv0qHaDw4VYplAqyiHaWPVShooZXVSki2fUxXbVjGEaPrgm8HBpiCwh2JbHuFLIPwrNl9nX6jqN8qkqr5KJyl1fAECp3CgkjotLhp1nd9bf1vp/7Hf5BP/oHVhFfYs4DKchz5pxzVFiKOZJgGIP5HaEGRpykhk//I/HryuqC4aR2rARlrFTCe24WsfhY2HX93djPbI9r4PuMPrWysZr6Zd7IgpPbyYaVncKThPaAOApVsvqOAQ1OuRZHglUrzhRLR6UGQeDPD6pZKbjd2bWOhIfLvWIh2YLxDU0Wp01JeNj6yqziO94P9ZDTfpObjrqqv+zfCMNksL12nXyO9fJJm/dPS4vsm6KENcLnIg3hh00jupo+NF3v0sTXV6EqZLokL04SOMRF7SKzHForvH0QmsDZ/J6o71SwKGcdFPJINlTfJSn99JHgDLFMHiOD34gT+65zvKwvxR57T4LwTPN/b7+f+SzPzLtb5KTSiSOoBEize4774vsjs+DshgHJPyCvffJV96TwJqddacf3EJ9QXzCpe6/SinlcoZB0N/anhzWn6AWaSMmt9If6IBiE8aSpIGK/son2V7MJKiXFDGdgWYvmft9MSmYU4x4mvjXZoAG1lhy7tekuKbXV3v1OfcQMFT6Ja3OKPKaIHWlwXKLHwremSOnupQFeenLpmm8BXXI59Xp6LzPVEx6D2Klsp5fLGI4kEe1n05yZQPvhzdlh2KuvYWZuN7rH/cJZffaSPg62rWymcOHjjTJy59TTw4C1yS+wEm7whym93z+ptGFWw0JGCzxcDD1Ou1wrDXKmmk65QKUiffqttEGkyRoBhpjzl2bDl0G04LhEj2pPY4QXNJmzldqQ8aCa1a KUQz+aH1 YlvAiC7nm/Cjm6sW2KmC948pNLuO83edVdBoM6Go3ShopX6WQpXv/hi5eAUev7IzMyNCwCn7gBDAd61Bdip7vnD6sxcqpo/HhSfoAhJhK+U+cALNO+B614KX6NbAN0vud3UI9jr/udQ+U+nte6lyFGnZ/+GxNoLwUmZBRnePheWE7phkecmGm9JVZp5J5ws20hW2CGbYTadfqA2kEwbq48nVj/FJRrDnu8oWJMXkJoA0LMuNZPHaAjaj9xOLPnqPV/3azRlg8WK3qlpGeQ1ViGt/N05DlG1DzuzpNen00R3mN86yaIae6OVt3+0xnQHpZrdtw0im5bc48qT/PQ39LOA1k7TXGwr6sTDLOU296+Ik+zrqgmenmHBc0PFjwblxEaCRN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/05/2024 18:12, Will Deacon wrote: > Hey Ryan, > > On Wed, May 08, 2024 at 04:38:01PM +0100, Ryan Roberts wrote: >> On 08/05/2024 15:24, kernel test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>> head: e7b4ef8fffaca247809337bb78daceb406659f2d >>> commit: f0f5863a0fb0fb48a5881c3f6acca1958899dd76 [10159/12060] arm64/mm: Remove PTE_PROT_NONE bit >>> config: arm64-randconfig-r013-20230528 (https://download.01.org/0day-ci/archive/20240508/202405082221.43rfWxz5-lkp@intel.com/config) >>> compiler: aarch64-linux-gcc (GCC) 13.2.0 >>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405082221.43rfWxz5-lkp@intel.com/reproduce) >>> >>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>> the same patch/commit), kindly add following tags >>> | Reported-by: kernel test robot >>> | Closes: https://lore.kernel.org/oe-kbuild-all/202405082221.43rfWxz5-lkp@intel.com/ >>> >>> All errors (new ones prefixed by >>): >>> >>> In file included from include/linux/pgtable.h:6, >>> from arch/arm64/include/asm/io.h:12, >>> from include/linux/io.h:13, >>> from include/linux/irq.h:20, >>> from include/asm-generic/hardirq.h:17, >>> from arch/arm64/include/asm/hardirq.h:17, >>> from include/linux/hardirq.h:11, >>> from include/linux/interrupt.h:11, >>> from include/linux/trace_recursion.h:5, >>> from include/linux/ftrace.h:10, >>> from arch/arm64/kernel/asm-offsets.c:12: >>> arch/arm64/include/asm/pgtable.h: In function 'pud_user_accessible_page': >>>>> arch/arm64/include/asm/pgtable.h:1102:16: error: implicit declaration of function 'pud_valid'; did you mean 'pmd_valid'? [-Werror=implicit-function-declaration] >>> 1102 | return pud_valid(pud) && !pud_table(pud) && (pud_user(pud) || pud_user_exec(pud)); >>> | ^~~~~~~~~ >>> | pmd_valid >> >> Hi Will, >> >> Looks like this is due to pud_valid() not being defined for >> CONFIG_PGTABLE_LEVELS <= 2. Seems to me that this is the cleanest solution. But >> pgtable folding breaks my brain so perhaps there is a better way? > > I think your approach is the right idea. pgtable-nopmd.h defines > pud_present() as 'return 1', but I think pud_valid() can be false given > that it's only used directly by the arch code. > >> What's the process here? Can you just merge this into the broken patch, or do I >> need to re-post the series, or post a fix patch formally? > > for-next/mm is stable, so please just submit proper patches on top of > that (and you can add a Fixes: tag as well). OK no problem - I've posted the patch. Sorry about this! > > Cheers, > > Will