From: xiujianfeng <xiujianfeng@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <hannes@cmpxchg.org>, <mhocko@kernel.org>,
<roman.gushchin@linux.dev>, <shakeel.butt@linux.dev>,
<muchun.song@linux.dev>, <akpm@linux-foundation.org>,
<cgroups@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] mm: memcg: use meaningful error code for return value
Date: Tue, 7 May 2024 19:17:35 +0800 [thread overview]
Message-ID: <b98d71e7-9b0f-4c8d-4c90-d1cc1eb730a2@huawei.com> (raw)
In-Reply-To: <Zjjg60ZW-d7r-DS9@casper.infradead.org>
On 2024/5/6 21:53, Matthew Wilcox wrote:
> On Mon, May 06, 2024 at 01:36:43PM +0000, Xiu Jianfeng wrote:
>> alloc_mem_cgroup_per_node_info() returns 1 if failed, use -ENOMEM
>> instead, which is more meaningful.
>
> This should probably be changed to return true/false instead of
> an int.
>
OK, already sent v2.
prev parent reply other threads:[~2024-05-07 11:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 13:36 [PATCH -next] mm: memcg: use meaningful error code for return value Xiu Jianfeng
2024-05-06 13:53 ` Matthew Wilcox
2024-05-06 14:49 ` Michal Hocko
2024-05-07 11:17 ` xiujianfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b98d71e7-9b0f-4c8d-4c90-d1cc1eb730a2@huawei.com \
--to=xiujianfeng@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).