From: Alexey Dobriyan <adobriyan@gmail.com>
To: gregkh@linuxfoundation.org
Cc: andrii@kernel.org, linux-fsdevel@vger.kernel.org,
brauner@kernel.org, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, gregkh@linuxfoundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] fs/procfs: implement efficient VMA querying API for /proc/<pid>/maps
Date: Sat, 4 May 2024 21:37:35 +0300 [thread overview]
Message-ID: <d5380af6-2e0b-4429-9336-192105259b57@p183> (raw)
Hi, Greg.
We've discussed this earlier.
Breaking news: /proc is slow, /sys too. Always have been.
Each /sys file is kind of fast, but there are so many files that
lookups eat all the runtime.
/proc files are bigger and thus slower. There is no way to filter
information.
If someone would post /proc today and said "it is 20-50-100" times
slower (which is true) than existing interfraces, linux-kernel would
not even laugh at him/her.
> slow in what way?
open/read/close is slow compared to equivalent not involving file
descriptors and textual processing.
> Text apis are good as everyone can handle them,
Text APIs provoke inefficient software:
Any noob can write
for name in name_list:
with open(f'/sys/kernel/slab/{name}/order') as f:
slab_order = int(f.read().split()[0])
See the problem? It's inefficient.
No open("/sys", O_DIRECTORY|O_PATH);
No openat(sys_fd, "kernel/slab", O_DIRECTORY|O_PATH);
No openat(sys_kernel_slab, buf, O_RDONLY);
buf is allocated dynamically many times probably, it's Python after all.
buf is longer than necessary. pathname buf won't be reused for result.
.split() conses a list, only to discard everything but first element.
Internally, sysfs allocates 1 page, instead of putting 1 byte somewhere
in userspace memory. /proc too.
Lookup is done every time (I don't think sysfs caches dentries in dcache
but I may be mistaken, so lookup is even slower).
Multiply by many times monitoring daemons run this (potentially disturbing
other tasks).
> ioctls are harder for obvious reasons.
What? ioctl are hard now?
Text APIs are garbage. If it's some crap in debugfs then noone cares.
But /proc/*/maps is not in debugfs.
Specifically on /proc/*/maps:
* _very_ well written software know that unescaping needs to be done on pathname
* (deleted) and (unreachable) junk. readlink and /proc/*/maps don't have
space for flags for unambigious deleted/unreachable status which
doesn't eat into pathname -- whoops
> I don't understand, is this a bug in the current files? If so, why not
> just fix that up?
open/read DO NOT accept file-specific flags, they are dumb like that.
In theory /proc/*/maps _could_ accept
pread(fd, buf, sizeof(buf), addr);
and return data for VMA containing "addr", but it can't because "addr"
is offset in textual file. Such offset is not interesting at all.
> And again "efficient" need to be quantified.
* roll eyes *
> Some people find text easier to handle for programmatic use :)
Some people should be barred from writing software by Programming Supreme Court
or something like that.
next reply other threads:[~2024-05-04 18:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 18:37 Alexey Dobriyan [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-04 0:30 [PATCH 0/5] ioctl()-based API to query VMAs from /proc/<pid>/maps Andrii Nakryiko
2024-05-04 0:30 ` [PATCH 2/5] fs/procfs: implement efficient VMA querying API for /proc/<pid>/maps Andrii Nakryiko
2024-05-04 15:28 ` Greg KH
2024-05-04 21:50 ` Andrii Nakryiko
2024-05-06 13:58 ` Arnaldo Carvalho de Melo
2024-05-06 18:05 ` Namhyung Kim
2024-05-06 18:51 ` Andrii Nakryiko
2024-05-06 18:53 ` Arnaldo Carvalho de Melo
2024-05-06 19:16 ` Arnaldo Carvalho de Melo
2024-05-07 21:55 ` Namhyung Kim
2024-05-06 18:41 ` Andrii Nakryiko
2024-05-06 20:35 ` Arnaldo Carvalho de Melo
2024-05-07 16:36 ` Andrii Nakryiko
2024-05-04 23:36 ` kernel test robot
2024-05-07 18:10 ` Liam R. Howlett
2024-05-07 18:52 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5380af6-2e0b-4429-9336-192105259b57@p183 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).