From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Kuan-Wei Chiu <visitorckw@gmail.com>,
ndesaulniers@google.com, morbo@google.com,
justinstitt@google.com, linux-kernel@vger.kernel.org,
maple-tree@lists.infradead.org, linux-mm@kvack.org,
llvm@lists.linux.dev, jserv@ccns.ncku.edu.tw
Subject: Re: [PATCH] maple_tree: Fix build failure with W=1 and LLVM=1
Date: Mon, 6 May 2024 10:29:09 -0400 [thread overview]
Message-ID: <u27qo2hnypvnziv36gdzs3eta76t4ia2sjxj7j7fhll3icljng@doeeizsosli2> (raw)
In-Reply-To: <20240504160257.02e20addebc407cb4a18da48@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> [240504 19:03]:
> On Fri, 3 May 2024 09:08:21 -0700 Nathan Chancellor <nathan@kernel.org> wrote:
>
> > This patch has effectively been sent four times now:
> >
> > https://lore.kernel.org/all/20220914101829.82000-1-jiapeng.chong@linux.alibaba.com/
> > https://lore.kernel.org/all/20230217084647.50471-1-jiapeng.chong@linux.alibaba.com/
> > https://lore.kernel.org/all/20230319132903.1702426-1-trix@redhat.com/
> > https://lore.kernel.org/all/20240503095027.747838-1-visitorckw@gmail.com/ (this change obviously)
> >
> > Your first comment from the 2022 patch:
> >
> > They're not used now, but they will be in a release or two.
> >
> > I think a few releases have passed since then :) I don't personally care
> > if there is a solution here or not, as I don't test with W=1 (there's
> > enough to do at W=0 :P), but maybe it is time for either __maybe_unused
> > (as that strikes at the heart of the issue) or at the very least a
> > comment saying "hey, these functions are currently unused but there are
> > plans for them to be used, so don't remove them", rather than just
> > saying the status quo?
>
> We could just slap a #if 0 around them. But I don't think it'll kill us to
> have to type them in again one day ;)
I've had people try to use this bit for other reasons, even with these
functions.
If we're dropping this code, then we should put something in to avoid it
disappearing on us.
I am working on the use of these functions in a branch, but I don't have
a timeline of when that feature will land.
Thanks,
Liam
prev parent reply other threads:[~2024-05-06 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 9:50 [PATCH] maple_tree: Fix build failure with W=1 and LLVM=1 Kuan-Wei Chiu
2024-05-03 12:20 ` Matthew Wilcox
2024-05-03 13:01 ` Kuan-Wei Chiu
2024-05-03 13:29 ` Matthew Wilcox
2024-05-03 16:08 ` Nathan Chancellor
2024-05-04 23:02 ` Andrew Morton
2024-05-06 14:29 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u27qo2hnypvnziv36gdzs3eta76t4ia2sjxj7j7fhll3icljng@doeeizsosli2 \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=maple-tree@lists.infradead.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=visitorckw@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).