From: Fiona Klute <fiona.klute@gmx.de>
To: linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>
Cc: "Kalle Valo" <kvalo@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, "Pavel Machek" <pavel@ucw.cz>,
"Ondřej Jirman" <megi@xff.cz>, "Fiona Klute" <fiona.klute@gmx.de>
Subject: [PATCH 0/9] rtw88: Add support for RTL8723CS/RTL8703B
Date: Fri, 2 Feb 2024 13:10:39 +0100 [thread overview]
Message-ID: <20240202121050.977223-1-fiona.klute@gmx.de> (raw)
This patch set adds a driver for RTL8723CS, which is used in the
Pinephone and a few other devices. It is a combined wifi/bluetooth
device, the wifi part is called RTL8703B. There is already a mainline
driver for the bluetooth part. RTL8703B is similar to the RTL8723D
chip already supported by rtw88. I've been using the out-of-tree
rtl8723cs driver as reference.
Station and monitor mode work well enough for daily use on my
Pinephone, I have not tested other modes yet. WOW firmware is
declared, but WOW isn't implemented yet. RX rates stay fairly low
still.
Ping-Ke Shih kindly offered to add the required s-o-b for the firmware
and help get it into linux-firmware when it's time, for testing now
please see the code I used to extract firmware from the out-of-tree
driver [1].
I'm trying to follow the "one file per patch" rule for new drivers
while integrating with the existing rtw88 code, please let me know if
I should split it differently. I'll be including a few questions for
reviewers in the relevant patch mails.
Thanks to Ping-Ke Shih for advice, and Ondřej Jirman for debug logs!
Requests for testers:
* I do not have any 8723d device. I made sure rtw88_8723d still
compiles, testing would be very welcome to make sure I didn't break
anything while moving common code to rtw8723x.
* Does anyone actually get the "unexpected cck agc report type"
warning? The out-of-tree driver also logs a warning and handles the
3 bit LNA index in that case, but the code could be simpler without
the workaround if it isn't needed.
* I've found mentions of RTL8703BS devices online which seem to be
wifi-only SDIO devices using RTL8703B, and posts telling people they
need to use the rtl8723cs driver to make them work. If anyone has
one of those I'd be curious if this driver works with it.
[1] https://github.com/airtower-luna/rtw8703b-fw-extractor
Fiona Klute (9):
wifi: rtw88: Shared module for rtw8723x devices
wifi: rtw88: Debug output for rtw8723x EFUSE
wifi: rtw88: Add definitions for 8703b chip
wifi: rtw88: Add rtw8703b.h
wifi: rtw88: Add rtw8703b.c
wifi: rtw88: Add rtw8703b_tables.h
wifi: rtw88: Add rtw8703b_tables.c
wifi: rtw88: Reset 8703b firmware before download
wifi: rtw88: SDIO device driver for RTL8723CS
drivers/net/wireless/realtek/rtw88/Kconfig | 22 +
drivers/net/wireless/realtek/rtw88/Makefile | 9 +
drivers/net/wireless/realtek/rtw88/mac.c | 6 +
drivers/net/wireless/realtek/rtw88/main.h | 3 +
drivers/net/wireless/realtek/rtw88/rtw8703b.c | 2106 +++++++++++++++++
drivers/net/wireless/realtek/rtw88/rtw8703b.h | 62 +
.../wireless/realtek/rtw88/rtw8703b_tables.c | 901 +++++++
.../wireless/realtek/rtw88/rtw8703b_tables.h | 14 +
.../net/wireless/realtek/rtw88/rtw8723cs.c | 34 +
drivers/net/wireless/realtek/rtw88/rtw8723d.c | 673 +-----
drivers/net/wireless/realtek/rtw88/rtw8723d.h | 269 +--
drivers/net/wireless/realtek/rtw88/rtw8723x.c | 720 ++++++
drivers/net/wireless/realtek/rtw88/rtw8723x.h | 517 ++++
include/linux/mmc/sdio_ids.h | 1 +
14 files changed, 4437 insertions(+), 900 deletions(-)
create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8703b.c
create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8703b.h
create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8703b_tables.c
create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8703b_tables.h
create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723cs.c
create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723x.c
create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723x.h
--
2.43.0
next reply other threads:[~2024-02-02 12:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 12:10 Fiona Klute [this message]
2024-02-02 12:10 ` [PATCH 1/9] wifi: rtw88: Shared module for rtw8723x devices Fiona Klute
2024-02-03 14:20 ` kernel test robot
2024-02-03 15:04 ` kernel test robot
2024-02-03 21:47 ` kernel test robot
2024-02-04 10:03 ` kernel test robot
2024-02-05 1:45 ` Ping-Ke Shih
2024-02-05 16:47 ` Fiona Klute
2024-02-06 0:59 ` Ping-Ke Shih
2024-02-02 12:10 ` [PATCH 2/9] wifi: rtw88: Debug output for rtw8723x EFUSE Fiona Klute
2024-02-05 2:17 ` Ping-Ke Shih
2024-02-05 17:10 ` Fiona Klute
2024-02-02 12:10 ` [PATCH 3/9] wifi: rtw88: Add definitions for 8703b chip Fiona Klute
2024-02-02 12:10 ` [PATCH 4/9] wifi: rtw88: Add rtw8703b.h Fiona Klute
2024-02-05 2:24 ` Ping-Ke Shih
2024-02-06 1:08 ` Fiona Klute
2024-02-06 2:02 ` Ping-Ke Shih
2024-02-02 12:10 ` [PATCH 5/9] wifi: rtw88: Add rtw8703b.c Fiona Klute
2024-02-05 3:01 ` Ping-Ke Shih
2024-02-05 19:06 ` Fiona Klute
2024-02-06 1:37 ` Ping-Ke Shih
2024-02-06 8:12 ` Pavel Machek
2024-02-07 5:58 ` Ping-Ke Shih
2024-02-02 12:10 ` [PATCH 6/9] wifi: rtw88: Add rtw8703b_tables.h Fiona Klute
2024-02-02 12:10 ` [PATCH 7/9] wifi: rtw88: Add rtw8703b_tables.c Fiona Klute
2024-02-02 12:10 ` [PATCH 8/9] wifi: rtw88: Reset 8703b firmware before download Fiona Klute
2024-02-05 3:05 ` Ping-Ke Shih
2024-02-02 12:10 ` [PATCH 9/9] wifi: rtw88: SDIO device driver for RTL8723CS Fiona Klute
2024-02-05 3:10 ` Ping-Ke Shih
2024-02-05 16:07 ` Ulf Hansson
2024-02-02 13:13 ` [PATCH 0/9] rtw88: Add support for RTL8723CS/RTL8703B Dmitry Antipov
2024-02-02 13:27 ` Fiona Klute
2024-02-02 13:54 ` Dmitry Antipov
2024-02-02 14:13 ` Fiona Klute
2024-02-02 20:19 ` Pavel Machek
2024-02-03 0:36 ` Fiona Klute
2024-02-02 20:44 ` Pavel Machek
2024-02-02 20:52 ` Pavel Machek
2024-02-03 11:33 ` Fiona Klute
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202121050.977223-1-fiona.klute@gmx.de \
--to=fiona.klute@gmx.de \
--cc=kvalo@kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=pavel@ucw.cz \
--cc=pkshih@realtek.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).