From: Linus Walleij <linus.walleij@linaro.org>
To: Adrian Hunter <adrian.hunter@intel.com>,
Angelo Dureghello <angelo.dureghello@timesys.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Cc: linux-mmc@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v2] mmc: sdhci-esdhc-mcf: Flag the sg_miter as atomic
Date: Wed, 28 Feb 2024 10:07:27 +0100 [thread overview]
Message-ID: <20240228-fix-sdhci-esdhc-mcf-2-v2-1-4ebb3fd691ea@linaro.org> (raw)
The sg_miter used to loop over the returned sglist from a
transfer in the esdhc subdriver for SDHCI can be called
from atomic context so the miter needs to be atomic.
sdhci_request_done() is always called from process context,
either as a work or as part of the threaded interrupt handler,
but the one case when we are actually calling .request_done()
from an atomic context is in sdhci_irq().
Fix this by flaggig the miter atomic so we always use
kmap_atomic().
Fixes: e8a167b84886 ("mmc: sdhci-esdhc-mcf: Use sg_miter for swapping")
Reported-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v2:
- Do the simpler fix and just use an atomic iterator, it
will work fine since esdhc_mcf_buffer_swap32() doesn't sleep.
- Link to v1: https://lore.kernel.org/r/20240222-fix-sdhci-esdhc-mcf-v1-1-fb87e04ca575@linaro.org
---
drivers/mmc/host/sdhci-esdhc-mcf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c
index 1909a11fd065..c97363e2d86c 100644
--- a/drivers/mmc/host/sdhci-esdhc-mcf.c
+++ b/drivers/mmc/host/sdhci-esdhc-mcf.c
@@ -313,7 +313,7 @@ static void esdhc_mcf_request_done(struct sdhci_host *host,
* transfer endiannes. A swap after the transfer is needed.
*/
sg_miter_start(&sgm, mrq->data->sg, mrq->data->sg_len,
- SG_MITER_TO_SG | SG_MITER_FROM_SG);
+ SG_MITER_ATOMIC | SG_MITER_TO_SG | SG_MITER_FROM_SG);
while (sg_miter_next(&sgm)) {
buffer = sgm.addr;
esdhc_mcf_buffer_swap32(buffer, sgm.length);
---
base-commit: 20af1ca418d2c0b11bc2a1fe8c0c88f67bcc2a7e
change-id: 20240228-fix-sdhci-esdhc-mcf-2-539cf338c3a3
Best regards,
--
Linus Walleij <linus.walleij@linaro.org>
next reply other threads:[~2024-02-28 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 9:07 Linus Walleij [this message]
2024-02-28 9:41 ` [PATCH v2] mmc: sdhci-esdhc-mcf: Flag the sg_miter as atomic Adrian Hunter
2024-02-28 13:03 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228-fix-sdhci-esdhc-mcf-2-v2-1-4ebb3fd691ea@linaro.org \
--to=linus.walleij@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=angelo.dureghello@timesys.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-mmc@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).