From: Ulf Hansson <ulf.hansson@linaro.org>
To: Elad Nachman <enachman@marvell.com>
Cc: huziji@marvell.com, adrian.hunter@intel.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Fix PHY init timeout issues
Date: Thu, 15 Feb 2024 17:51:02 +0100 [thread overview]
Message-ID: <CAPDyKFpNL_zFgzSNgaSRqaH8tDNjwB16ZD1YGwqM64vcQ2oxtA@mail.gmail.com> (raw)
In-Reply-To: <20240215161613.1736051-1-enachman@marvell.com>
On Thu, 15 Feb 2024 at 17:16, Elad Nachman <enachman@marvell.com> wrote:
>
> From: Elad Nachman <enachman@marvell.com>
>
> Fix PHY init timeout issues:
>
> 1. Clock Stability issue causing PHY timeout
>
> 2. Timeout taking longer than needed on AC5X.
> Solve by constantly testing the PHY init bit
> until it toggles, but up to 100X timeout factor.
>
> v2:
> 1) convert polling loop to read_poll_timeout()
> for both patches.
>
> Elad Nachman (2):
> mmc: xenon: fix PHY init clock stability
> mmc: xenon: add timeout for PHY init complete
>
> drivers/mmc/host/sdhci-xenon-phy.c | 48 ++++++++++++++++++++++++------
> 1 file changed, 39 insertions(+), 9 deletions(-)
>
The series looks good to me. Although, I assume we should tag this for
stable kernels too and possibly add a fixes tag?
Moreover, it would be nice to get an ack from Hu Ziji.
Kind regards
Uffe
next prev parent reply other threads:[~2024-02-15 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 16:16 [PATCH v2 0/2] Fix PHY init timeout issues Elad Nachman
2024-02-15 16:16 ` [PATCH v2 1/2] mmc: xenon: fix PHY init clock stability Elad Nachman
2024-02-15 16:16 ` [PATCH v2 2/2] mmc: xenon: add timeout for PHY init complete Elad Nachman
2024-02-15 16:51 ` Ulf Hansson [this message]
2024-02-15 17:01 ` [EXT] Re: [PATCH v2 0/2] Fix PHY init timeout issues Elad Nachman
2024-02-16 8:28 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFpNL_zFgzSNgaSRqaH8tDNjwB16ZD1YGwqM64vcQ2oxtA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=enachman@marvell.com \
--cc=huziji@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).