From: Luis Chamberlain <mcgrof@kernel.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: linux-modules@vger.kernel.org, stable@kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH] module/decompress: Fix error checking on zstd decompression
Date: Thu, 1 Jun 2023 14:40:05 -0700 [thread overview]
Message-ID: <ZHkQNQK5zrzo4Cq2@bombadil.infradead.org> (raw)
In-Reply-To: <20230601212331.567483-1-lucas.demarchi@intel.com>
On Thu, Jun 01, 2023 at 02:23:31PM -0700, Lucas De Marchi wrote:
> While implementing support for in-kernel decompression in kmod,
> finit_module() was returning a very suspicious value:
>
> finit_module(3, "", MODULE_INIT_COMPRESSED_FILE) = 18446744072717407296
>
> It turns out the check for module_get_next_page() failing is wrong,
> and hence the decompression was not really taking place. Invert
> the condition to fix it.
>
> Fixes: 169a58ad824d ("module/decompress: Support zstd in-kernel decompression")
> Cc: stable@kernel.org
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Applied and pushed, will send a pull to Linus right away, thanks!
Luis
prev parent reply other threads:[~2023-06-01 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 21:23 [PATCH] module/decompress: Fix error checking on zstd decompression Lucas De Marchi
2023-06-01 21:40 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHkQNQK5zrzo4Cq2@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=stable@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).