From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jens Axboe <axboe@kernel.dk>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: manual merge of the scsi-mkp tree with the block tree
Date: Fri, 26 Apr 2024 16:01:15 +1000 [thread overview]
Message-ID: <20240426160115.7797a43a@canb.auug.org.au> (raw)
In-Reply-To: <20240418145554.7a93325b@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 3582 bytes --]
Hi all,
On Thu, 18 Apr 2024 14:55:54 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next merge of the scsi-mkp tree got conflicts in:
>
> block/blk-settings.c
> include/linux/blkdev.h
>
> between commit:
>
> e4eb37cc0f3e ("block: Remove elevator required features")
>
> from the block tree and commit:
>
> ec84ca4025c0 ("scsi: block: Remove now unused queue limits helpers")
>
> from the scsi-mkp tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> diff --cc block/blk-settings.c
> index 8e1d7ed52fef,292aadf8d807..000000000000
> --- a/block/blk-settings.c
> +++ b/block/blk-settings.c
> @@@ -1048,28 -822,22 +825,6 @@@ void blk_queue_write_cache(struct reque
> }
> EXPORT_SYMBOL_GPL(blk_queue_write_cache);
>
> --/**
> - * blk_queue_can_use_dma_map_merging - configure queue for merging segments.
> - * @q: the request queue for the device
> - * @dev: the device pointer for dma
> - * blk_queue_required_elevator_features - Set a queue required elevator features
> - * @q: the request queue for the target device
> - * @features: Required elevator features OR'ed together
> -- *
> - * Tell the block layer about merging the segments by dma map of @q.
> - * Tell the block layer that for the device controlled through @q, only the
> - * only elevators that can be used are those that implement at least the set of
> - * features specified by @features.
> -- */
> - bool blk_queue_can_use_dma_map_merging(struct request_queue *q,
> - struct device *dev)
> -void blk_queue_required_elevator_features(struct request_queue *q,
> - unsigned int features)
> --{
> - unsigned long boundary = dma_get_merge_boundary(dev);
> -
> - if (!boundary)
> - return false;
> -
> - /* No need to update max_segment_size. see blk_queue_virt_boundary() */
> - blk_queue_virt_boundary(q, boundary);
> -
> - return true;
> - q->required_elevator_features = features;
> --}
> - EXPORT_SYMBOL_GPL(blk_queue_can_use_dma_map_merging);
> -EXPORT_SYMBOL_GPL(blk_queue_required_elevator_features);
> --
> /**
> * disk_set_zoned - inidicate a zoned device
> * @disk: gendisk to configure
> diff --cc include/linux/blkdev.h
> index 2c535af79529,e3c7082efa39..000000000000
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@@ -924,9 -942,15 +926,6 @@@ disk_alloc_independent_access_ranges(st
> void disk_set_independent_access_ranges(struct gendisk *disk,
> struct blk_independent_access_ranges *iars);
>
> - extern bool blk_queue_can_use_dma_map_merging(struct request_queue *q,
> - struct device *dev);
> -/*
> - * Elevator features for blk_queue_required_elevator_features:
> - */
> -/* Supports zoned block devices sequential write constraint */
> -#define ELEVATOR_F_ZBD_SEQ_WRITE (1U << 0)
> -
> -extern void blk_queue_required_elevator_features(struct request_queue *q,
> - unsigned int features);
> --
> bool __must_check blk_get_queue(struct request_queue *);
> extern void blk_put_queue(struct request_queue *);
>
This is now a conflict between the scsi tree and the block tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-04-26 6:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 4:55 linux-next: manual merge of the scsi-mkp tree with the block tree Stephen Rothwell
2024-04-18 5:57 ` Christoph Hellwig
2024-04-26 6:01 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-21 22:06 broonie
2022-03-01 7:29 ` Stephen Rothwell
2022-02-21 21:59 broonie
2022-02-22 5:57 ` Jinpu Wang
2022-03-01 7:31 ` Stephen Rothwell
2021-01-27 6:58 Stephen Rothwell
2019-02-11 4:23 Stephen Rothwell
2017-04-26 5:47 Stephen Rothwell
2016-11-09 2:54 Stephen Rothwell
2016-11-11 19:55 ` Martin K. Petersen
2016-11-17 2:44 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426160115.7797a43a@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).