From: Chuck Lever <cel@kernel.org>
To: Jeff Layton <jlayton@kernel.org>, Scott Mayhew <smayhew@redhat.com>
Cc: Chuck Lever <chuck.lever@oracle.com>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH v4] nfsd: fix file change detection in CB_GETATTR
Date: Wed, 8 Apr 2026 08:51:53 -0400 [thread overview]
Message-ID: <177565264307.804387.4529450531664012401.b4-ty@b4> (raw)
In-Reply-To: <20260407220857.1826441-1-smayhew@redhat.com>
From: Chuck Lever <chuck.lever@oracle.com>
On Tue, 07 Apr 2026 18:08:57 -0400, Scott Mayhew wrote:
> RFC 8881, section 10.4.3 doesn't say anything about caching the file
> size in the delegation record, nor does it say anything about comparing
> a cached file size with the size reported by the client in the
> CB_GETATTR reply for the purpose of determining if the client holds
> modified data for the file.
>
> What section 10.4.3 of RFC 8881 does say is that the server should
> compare the *current* file size with the size reported by the client
> holding the delegation in the CB_GETATTR reply, and if they differ to
> treat it as a modification regardless of the change attribute retrieved
> via the CB_GETATTR.
>
> [...]
Applied to nfsd-testing, thanks! And, thanks for confirming
applicability to LTS kernels. Cc: stable@ added.
[1/1] nfsd: fix file change detection in CB_GETATTR
commit: 17a5b972dbf13cb2a7ef38317f971d9ccfe8471b
--
Chuck Lever
prev parent reply other threads:[~2026-04-08 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 22:08 [PATCH v4] nfsd: fix file change detection in CB_GETATTR Scott Mayhew
2026-04-08 12:51 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177565264307.804387.4529450531664012401.b4-ty@b4 \
--to=cel@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=smayhew@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).