Linux-NFS Archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <cel@kernel.org>
To: NeilBrown <neil@brown.name>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
	Trond Myklebust <trondmy@kernel.org>,
	Anna Schumaker <anna@kernel.org>,
	Jeff Layton <jlayton@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sunrpc: start cache request seqno at 1 to fix netlink GET_REQS
Date: Mon, 13 Apr 2026 13:24:36 -0400	[thread overview]
Message-ID: <177610106224.4271.14936503257520657746.b4-ty@oracle.com> (raw)
In-Reply-To: <20260411-exportd-nl-v1-1-ca582b6d9434@kernel.org>

From: Chuck Lever <chuck.lever@oracle.com>

On Sat, 11 Apr 2026 17:12:16 -0400, Jeff Layton wrote:
> sunrpc_cache_requests_snapshot() filters requests with
> crq->seqno <= min_seqno. The min_seqno for the first netlink
> dump call is cb->args[0] which is 0. Since next_seqno was
> initialized to 0, the very first cache request got seqno=0
> and was silently skipped by the snapshot (0 <= 0 is true).
> 
> This caused netlink-based GET_REQS to return 0 pending requests
> even when a request was queued, preventing mountd from resolving
> cache entries (particularly expkey/nfsd.fh). The unresolved
> CACHE_PENDING state blocked all further notifications for the
> entry, leading to permanent NFS4ERR_DELAY hangs.
> 
> [...]

Applied to nfsd-testing, thanks!

[1/1] sunrpc: start cache request seqno at 1 to fix netlink GET_REQS
      commit: 2dd2484661eb089e5eb2ba9da4b87decb0f3be36

--
Chuck Lever <chuck.lever@oracle.com>

      reply	other threads:[~2026-04-13 17:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-11 21:12 [PATCH] sunrpc: start cache request seqno at 1 to fix netlink GET_REQS Jeff Layton
2026-04-13 17:24 ` Chuck Lever [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177610106224.4271.14936503257520657746.b4-ty@oracle.com \
    --to=cel@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=anna@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).