Linux-NFS Archive mirror
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: libtirpc-devel@lists.sourceforge.net
Cc: linux-nfs@vger.kernel.org, Khem Raj <khem.raj@oss.qualcomm.com>
Subject: [PATCH] libtirpc: fix bindresvport build with clang-22/C23
Date: Tue, 31 Mar 2026 23:09:43 -0700	[thread overview]
Message-ID: <20260401060943.2578248-1-khem.raj@oss.qualcomm.com> (raw)

bindresvport() is defined using old K&R-style syntax, which breaks when
building libtirpc with clang-22 in gnu23 mode.

Convert it to a prototype-style definition. This is a no-op change
intended only to restore compatibility with modern C compilers.

Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 src/bindresvport.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/bindresvport.c b/src/bindresvport.c
index 7b2056d..eea6589 100644
--- a/src/bindresvport.c
+++ b/src/bindresvport.c
@@ -57,9 +57,7 @@ extern pthread_mutex_t port_lock;
  * Bind a socket to a privileged IP port
  */
 int
-bindresvport(sd, sin)
-        int sd;
-        struct sockaddr_in *sin;
+bindresvport(int sd, struct sockaddr_in *sin)
 {
         return bindresvport_sa(sd, (struct sockaddr *)sin);
 }

                 reply	other threads:[~2026-04-01  6:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401060943.2578248-1-khem.raj@oss.qualcomm.com \
    --to=raj.khem@gmail.com \
    --cc=khem.raj@oss.qualcomm.com \
    --cc=libtirpc-devel@lists.sourceforge.net \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).