From: Steve Dickson <steved@redhat.com>
To: Olga Kornievskaia <okorniev@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 1/1] nfsdctl: check for listeners before starting threads
Date: Sun, 29 Mar 2026 16:52:08 -0400 [thread overview]
Message-ID: <3dc18fa8-31f1-4aa4-a566-b6e141184303@redhat.com> (raw)
In-Reply-To: <20260323203710.83237-1-okorniev@redhat.com>
On 3/23/26 4:37 PM, Olga Kornievskaia wrote:
> When a thread command is executed and yet no listeners have been
> added prior to it, instead of failing with EIO error print an
> informative error. Also, "thread 0" command should not error
> regardless of the listener status.
>
> Signed-off-by: Olga Kornievskaia <okorniev@redhat.com>
Committed... (tag: nfs-utils-2-9-1-rc2)
steved.
> ---
> utils/nfsdctl/nfsdctl.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/utils/nfsdctl/nfsdctl.c b/utils/nfsdctl/nfsdctl.c
> index 6a20d180..ac23e753 100644
> --- a/utils/nfsdctl/nfsdctl.c
> +++ b/utils/nfsdctl/nfsdctl.c
> @@ -162,6 +162,8 @@ static const char *nfsd4_ops[] = {
> [OP_REMOVEXATTR] = "OP_REMOVEXATTR",
> };
>
> +static int fetch_current_listeners(struct nl_sock *sock);
> +
> static int error_handler(struct sockaddr_nl *nla, struct nlmsgerr *err,
> void *arg)
> {
> @@ -721,6 +723,7 @@ static int threads_func(struct nl_sock *sock, int argc, char **argv)
> int *pool_threads = NULL;
> int minthreads = -1;
> int opt, pools = 0;
> + bool zero_threads = false;
>
> optind = 1;
> while ((opt = getopt_long(argc, argv, "hm:", threads_options, NULL)) != -1) {
> @@ -762,12 +765,31 @@ static int threads_func(struct nl_sock *sock, int argc, char **argv)
> }
>
> pool_threads[i] = strtol(targv[i], &endptr, 0);
> + if (!pool_threads[i])
> + zero_threads = true;
> if (!endptr || *endptr != '\0') {
> xlog(L_ERROR, "Invalid threads value %s.", argv[1]);
> return 1;
> }
> }
> }
> + /* check if there are active listeners added */
> + if (fetch_current_listeners(sock)) {
> + xlog(L_ERROR, "Unable to determine if listeners were added");
> + return 1;
> + }
> + if (!nfsd_socket_count) {
> + if (zero_threads) {
> + /* Note: we can never have a server with threads and no
> + * listener. If we ever add functionality to remove
> + * listeners on an active server, we need to revisit this.
> + */
> + return 0;
> + }
> + xlog(L_ERROR, "No active listeners added, not starting threads");
> + return 1;
> + }
> +
> return threads_doit(sock, cmd, 0, 0, pools, pool_threads, NULL, minthreads);
> }
>
prev parent reply other threads:[~2026-03-29 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 20:37 [PATCH v2 1/1] nfsdctl: check for listeners before starting threads Olga Kornievskaia
2026-03-29 20:52 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dc18fa8-31f1-4aa4-a566-b6e141184303@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=okorniev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).