From: Stefan Metzmacher <metze@samba.org>
To: David Howells <dhowells@redhat.com>,
Christian Brauner <christian@brauner.io>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@infradead.org>
Cc: Paulo Alcantara <pc@manguebit.com>, Jens Axboe <axboe@kernel.dk>,
Leon Romanovsky <leon@kernel.org>,
Steve French <sfrench@samba.org>,
ChenXiaoSong <chenxiaosong@chenxiaosong.com>,
Marc Dionne <marc.dionne@auristor.com>,
Eric Van Hensbergen <ericvh@kernel.org>,
Dominique Martinet <asmadeus@codewreck.org>,
Ilya Dryomov <idryomov@gmail.com>,
Trond Myklebust <trondmy@kernel.org>,
netfs@lists.linux.dev, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
ceph-devel@vger.kernel.org, v9fs@lists.linux.dev,
linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Paulo Alcantara <pc@manguebit.org>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH 19/26] cifs: Remove support for ITER_KVEC/BVEC/FOLIOQ from smb_extract_iter_to_rdma()
Date: Sun, 29 Mar 2026 12:39:46 +0200 [thread overview]
Message-ID: <3f19c05a-d8aa-4ce5-8bcf-b51a1f110cb5@samba.org> (raw)
In-Reply-To: <20260326104544.509518-20-dhowells@redhat.com>
Hi David,
in ksmbd-for-next smbdirect_map_sges_from_iter is also called
in the server from smb_direct_writev() =>
smbdirect_connection_send_iter() =>
smbdirect_connection_send_single_iter()
So we still need ITER_KVEC.
Thanks!
metze
Am 26.03.26 um 11:45 schrieb David Howells:
> netfslib now only presents an bvecq queue and an associated ITER_BVECQ
> iterator to the filesystem, so it isn't going to see ITER_KVEC, ITER_BVEC
> or ITER_FOLIOQ iterators. So remove that code.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Steve French <sfrench@samba.org>
> cc: Paulo Alcantara <pc@manguebit.org>
> cc: Shyam Prasad N <sprasad@microsoft.com>
> cc: Tom Talpey <tom@talpey.com>
> cc: linux-cifs@vger.kernel.org
> cc: netfs@lists.linux.dev
> cc: linux-fsdevel@vger.kernel.org
> ---
> fs/smb/client/smbdirect.c | 165 --------------------------------------
> 1 file changed, 165 deletions(-)
>
> diff --git a/fs/smb/client/smbdirect.c b/fs/smb/client/smbdirect.c
> index f8a6be83db98..d9e026d5e9f9 100644
> --- a/fs/smb/client/smbdirect.c
> +++ b/fs/smb/client/smbdirect.c
> @@ -3142,162 +3142,6 @@ static bool smb_set_sge(struct smb_extract_to_rdma *rdma,
> return true;
> }
>
> -/*
> - * Extract page fragments from a BVEC-class iterator and add them to an RDMA
> - * element list. The pages are not pinned.
> - */
> -static ssize_t smb_extract_bvec_to_rdma(struct iov_iter *iter,
> - struct smb_extract_to_rdma *rdma,
> - ssize_t maxsize)
> -{
> - const struct bio_vec *bv = iter->bvec;
> - unsigned long start = iter->iov_offset;
> - unsigned int i;
> - ssize_t ret = 0;
> -
> - for (i = 0; i < iter->nr_segs; i++) {
> - size_t off, len;
> -
> - len = bv[i].bv_len;
> - if (start >= len) {
> - start -= len;
> - continue;
> - }
> -
> - len = min_t(size_t, maxsize, len - start);
> - off = bv[i].bv_offset + start;
> -
> - if (!smb_set_sge(rdma, bv[i].bv_page, off, len))
> - return -EIO;
> -
> - ret += len;
> - maxsize -= len;
> - if (rdma->nr_sge >= rdma->max_sge || maxsize <= 0)
> - break;
> - start = 0;
> - }
> -
> - if (ret > 0)
> - iov_iter_advance(iter, ret);
> - return ret;
> -}
> -
> -/*
> - * Extract fragments from a KVEC-class iterator and add them to an RDMA list.
> - * This can deal with vmalloc'd buffers as well as kmalloc'd or static buffers.
> - * The pages are not pinned.
> - */
> -static ssize_t smb_extract_kvec_to_rdma(struct iov_iter *iter,
> - struct smb_extract_to_rdma *rdma,
> - ssize_t maxsize)
> -{
> - const struct kvec *kv = iter->kvec;
> - unsigned long start = iter->iov_offset;
> - unsigned int i;
> - ssize_t ret = 0;
> -
> - for (i = 0; i < iter->nr_segs; i++) {
> - struct page *page;
> - unsigned long kaddr;
> - size_t off, len, seg;
> -
> - len = kv[i].iov_len;
> - if (start >= len) {
> - start -= len;
> - continue;
> - }
> -
> - kaddr = (unsigned long)kv[i].iov_base + start;
> - off = kaddr & ~PAGE_MASK;
> - len = min_t(size_t, maxsize, len - start);
> - kaddr &= PAGE_MASK;
> -
> - maxsize -= len;
> - do {
> - seg = min_t(size_t, len, PAGE_SIZE - off);
> -
> - if (is_vmalloc_or_module_addr((void *)kaddr))
> - page = vmalloc_to_page((void *)kaddr);
> - else
> - page = virt_to_page((void *)kaddr);
> -
> - if (!smb_set_sge(rdma, page, off, seg))
> - return -EIO;
> -
> - ret += seg;
> - len -= seg;
> - kaddr += PAGE_SIZE;
> - off = 0;
> - } while (len > 0 && rdma->nr_sge < rdma->max_sge);
> -
> - if (rdma->nr_sge >= rdma->max_sge || maxsize <= 0)
> - break;
> - start = 0;
> - }
> -
> - if (ret > 0)
> - iov_iter_advance(iter, ret);
> - return ret;
> -}
> -
> -/*
> - * Extract folio fragments from a FOLIOQ-class iterator and add them to an RDMA
> - * list. The folios are not pinned.
> - */
> -static ssize_t smb_extract_folioq_to_rdma(struct iov_iter *iter,
> - struct smb_extract_to_rdma *rdma,
> - ssize_t maxsize)
> -{
> - const struct folio_queue *folioq = iter->folioq;
> - unsigned int slot = iter->folioq_slot;
> - ssize_t ret = 0;
> - size_t offset = iter->iov_offset;
> -
> - BUG_ON(!folioq);
> -
> - if (slot >= folioq_nr_slots(folioq)) {
> - folioq = folioq->next;
> - if (WARN_ON_ONCE(!folioq))
> - return -EIO;
> - slot = 0;
> - }
> -
> - do {
> - struct folio *folio = folioq_folio(folioq, slot);
> - size_t fsize = folioq_folio_size(folioq, slot);
> -
> - if (offset < fsize) {
> - size_t part = umin(maxsize, fsize - offset);
> -
> - if (!smb_set_sge(rdma, folio_page(folio, 0), offset, part))
> - return -EIO;
> -
> - offset += part;
> - ret += part;
> - maxsize -= part;
> - }
> -
> - if (offset >= fsize) {
> - offset = 0;
> - slot++;
> - if (slot >= folioq_nr_slots(folioq)) {
> - if (!folioq->next) {
> - WARN_ON_ONCE(ret < iter->count);
> - break;
> - }
> - folioq = folioq->next;
> - slot = 0;
> - }
> - }
> - } while (rdma->nr_sge < rdma->max_sge && maxsize > 0);
> -
> - iter->folioq = folioq;
> - iter->folioq_slot = slot;
> - iter->iov_offset = offset;
> - iter->count -= ret;
> - return ret;
> -}
> -
> /*
> * Extract memory fragments from a BVECQ-class iterator and add them to an RDMA
> * list. The folios are not pinned.
> @@ -3373,15 +3217,6 @@ static ssize_t smb_extract_iter_to_rdma(struct iov_iter *iter, size_t len,
> int before = rdma->nr_sge;
>
> switch (iov_iter_type(iter)) {
> - case ITER_BVEC:
> - ret = smb_extract_bvec_to_rdma(iter, rdma, len);
> - break;
> - case ITER_KVEC:
> - ret = smb_extract_kvec_to_rdma(iter, rdma, len);
> - break;
> - case ITER_FOLIOQ:
> - ret = smb_extract_folioq_to_rdma(iter, rdma, len);
> - break;
> case ITER_BVECQ:
> ret = smb_extract_bvecq_to_rdma(iter, rdma, len);
> break;
>
next prev parent reply other threads:[~2026-03-29 10:39 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 10:45 [PATCH 00/26] netfs: Keep track of folios in a segmented bio_vec[] chain David Howells
2026-03-26 10:45 ` [PATCH 01/26] netfs: Fix NULL pointer dereference in netfs_unbuffered_write() on retry David Howells
2026-03-28 18:20 ` Paulo Alcantara
2026-03-26 10:45 ` [PATCH 02/26] netfs: Fix kernel BUG in netfs_limit_iter() for ITER_KVEC iterators David Howells
2026-03-28 18:21 ` Paulo Alcantara
2026-03-26 10:45 ` [PATCH 03/26] netfs: fix VM_BUG_ON_FOLIO() issue in netfs_write_begin() call David Howells
2026-03-28 18:24 ` Paulo Alcantara
2026-03-26 10:45 ` [PATCH 04/26] netfs: fix error handling in netfs_extract_user_iter() David Howells
2026-03-26 10:45 ` [PATCH 05/26] netfs: Fix read abandonment during retry David Howells
2026-03-28 18:25 ` Paulo Alcantara
2026-03-26 10:45 ` [PATCH 06/26] netfs: Fix the handling of stream->front by removing it David Howells
2026-03-28 18:25 ` Paulo Alcantara
2026-03-26 10:45 ` [PATCH 07/26] cachefiles: Fix excess dput() after end_removing() David Howells
[not found] ` <CA+yaA_=gpTnueByzFNYrqNL_qSC2rE4iGDjLHtJap-=_rhE3HQ@mail.gmail.com>
2026-03-26 11:10 ` David Howells
2026-03-28 18:29 ` Paulo Alcantara
2026-03-26 10:45 ` [PATCH 08/26] cachefiles: Don't rely on backing fs storage map for most use cases David Howells
2026-03-26 10:45 ` [PATCH 09/26] mm: Make readahead store folio count in readahead_control David Howells
2026-03-28 18:34 ` Paulo Alcantara
2026-03-26 10:45 ` [PATCH 10/26] netfs: Bulk load the readahead-provided folios up front David Howells
2026-03-28 18:36 ` Paulo Alcantara
2026-03-26 10:45 ` [PATCH 11/26] Add a function to kmap one page of a multipage bio_vec David Howells
2026-03-28 18:39 ` Paulo Alcantara
2026-03-26 10:45 ` [PATCH 12/26] iov_iter: Add a segmented queue of bio_vec[] David Howells
2026-03-28 18:39 ` Paulo Alcantara
2026-03-26 10:45 ` [PATCH 13/26] netfs: Add some tools for managing bvecq chains David Howells
2026-03-26 10:45 ` [PATCH 14/26] netfs: Add a function to extract from an iter into a bvecq David Howells
2026-03-26 10:45 ` [PATCH 15/26] afs: Use a bvecq to hold dir content rather than folioq David Howells
2026-03-26 10:45 ` [PATCH 16/26] cifs: Use a bvecq for buffering instead of a folioq David Howells
2026-03-26 10:45 ` [PATCH 17/26] cifs: Support ITER_BVECQ in smb_extract_iter_to_rdma() David Howells
2026-03-29 10:36 ` Stefan Metzmacher
2026-03-26 10:45 ` [PATCH 18/26] netfs: Switch to using bvecq rather than folio_queue and rolling_buffer David Howells
2026-03-26 10:45 ` [PATCH 19/26] cifs: Remove support for ITER_KVEC/BVEC/FOLIOQ from smb_extract_iter_to_rdma() David Howells
2026-03-29 10:39 ` Stefan Metzmacher [this message]
2026-03-26 10:45 ` [PATCH 20/26] netfs: Remove netfs_alloc/free_folioq_buffer() David Howells
2026-03-26 10:45 ` [PATCH 21/26] netfs: Remove netfs_extract_user_iter() David Howells
2026-03-26 10:45 ` [PATCH 22/26] iov_iter: Remove ITER_FOLIOQ David Howells
2026-03-26 10:45 ` [PATCH 23/26] netfs: Remove folio_queue and rolling_buffer David Howells
2026-03-26 10:45 ` [PATCH 24/26] netfs: Check for too much data being read David Howells
2026-03-26 10:45 ` [PATCH 25/26] netfs: Limit the the minimum trigger for progress reporting David Howells
2026-03-26 14:19 ` ChenXiaoSong
2026-03-26 10:45 ` [PATCH 26/26] netfs: Combine prepare and issue ops and grab the buffers on request David Howells
2026-03-29 11:07 ` [PATCH 00/26] netfs: Keep track of folios in a segmented bio_vec[] chain Stefan Metzmacher
2026-03-30 10:49 ` David Howells
2026-03-30 13:57 ` Stefan Metzmacher
2026-04-14 8:02 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f19c05a-d8aa-4ce5-8bcf-b51a1f110cb5@samba.org \
--to=metze@samba.org \
--cc=asmadeus@codewreck.org \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=chenxiaosong@chenxiaosong.com \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=ericvh@kernel.org \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=leon@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.com \
--cc=pc@manguebit.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).