From: yangerkun <yangerkun@huaweicloud.com>
To: Chuck Lever <cel@kernel.org>,
misanjum@linux.ibm.com, jlayton@kernel.org, neil@brown.name,
okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com,
Yang Erkun <yangerkun@huawei.com>
Cc: Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org, yi.zhang@huawei.com,
chengzhihao1@huawei.com, lilingfeng3@huawei.com
Subject: Re: [PATCH v2] Revert "NFSD: Defer sub-object cleanup in export put callbacks"
Date: Thu, 14 May 2026 09:05:20 +0800 [thread overview]
Message-ID: <52979c95-bf8a-48d6-b5af-45c82af2cbfc@huaweicloud.com> (raw)
In-Reply-To: <177868131676.213195.3678046994150964706.b4-ty@b4>
在 2026/5/13 22:09, Chuck Lever 写道:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> On Wed, 13 May 2026 10:42:52 +0800, Yang Erkun wrote:
>> This reverts commit 48db892356d6cb80f6942885545de4a6dd8d2a29.
>>
>> Commit 48db892356d6 ("NFSD: Defer sub-object cleanup in export put
>> callbacks") describes an issue where calling svc_export_put, path_put,
>> and auth_domain_put directly can cause use-after-free (UAF) errors when
>> accessing ex_path or ex_client->name. But after discussion in [1], it
>> seems cannot happen and either will introduce a gression that was
>> already fixed by commit 69d803c40ede ("nfsd: Revert "nfsd: release
>> svc_expkey/svc_export with rcu_work""). Therefore, reverting commit
>> 48db892356d6 ("NFSD: Defer sub-object cleanup in export put callbacks")
>> is necessary to fix this regression.
>>
>> [...]
>
> Applied to nfsd-testing with an expanded commit message to preserve
> the context of our discussions.
Certainly, this commit message could be more detailed. Thank you for
taking the time to do this!
>
> [1/1] Revert "NFSD: Defer sub-object cleanup in export put callbacks"
> commit: ef4e34669aa1a15d2f5ba86fd433fcac9aee81c9
>
> --
> Chuck Lever <chuck.lever@oracle.com>
next prev parent reply other threads:[~2026-05-14 1:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 2:42 [PATCH v2] Revert "NFSD: Defer sub-object cleanup in export put callbacks" Yang Erkun
2026-05-13 14:09 ` Chuck Lever
2026-05-14 1:05 ` yangerkun [this message]
2026-05-18 16:57 ` Calum Mackay
2026-05-18 18:28 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52979c95-bf8a-48d6-b5af-45c82af2cbfc@huaweicloud.com \
--to=yangerkun@huaweicloud.com \
--cc=Dai.Ngo@oracle.com \
--cc=cel@kernel.org \
--cc=chengzhihao1@huawei.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=lilingfeng3@huawei.com \
--cc=linux-nfs@vger.kernel.org \
--cc=misanjum@linux.ibm.com \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).