From: yangerkun <yangerkun@huaweicloud.com>
To: Chuck Lever <cel@kernel.org>, yangerkun <yangerkun@huawei.com>,
Chuck Lever <chuck.lever@oracle.com>,
Misbah Anjum N <misanjum@linux.ibm.com>,
Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org, yi.zhang@huawei.com,
Zhihao Cheng <chengzhihao1@huawei.com>,
Li Lingfeng <lilingfeng3@huawei.com>
Subject: Re: [PATCH] Revert "NFSD: Defer sub-object cleanup in export put callbacks"
Date: Wed, 13 May 2026 09:55:17 +0800 [thread overview]
Message-ID: <56174eb9-d074-4f8e-872b-f13b09813b2c@huaweicloud.com> (raw)
In-Reply-To: <55ec615a-3b80-4608-ac52-1c0215b789a7@app.fastmail.com>
在 2026/5/13 9:36, Chuck Lever 写道:
>
>
> On Tue, May 12, 2026, at 9:27 PM, yangerkun wrote:
>> 在 2026/5/12 21:48, Chuck Lever 写道:
>>>
>>> On Mon, May 11, 2026, at 10:33 PM, Yang Erkun wrote:
>
>>>> diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
>>>> index 665153f1720e..0baa58d1dbfc 100644
>>>> --- a/fs/nfsd/export.c
>>>> +++ b/fs/nfsd/export.c
>>>> @@ -36,30 +36,19 @@
>>>> * second map contains a reference to the entry in the first map.
>>>> */
>>>>
>>>> -static struct workqueue_struct *nfsd_export_wq;
>>>> -
>>>
>>> Hi Erkun -
>>>
>>> This patch doesn't apply to the nfsd-testing branch. What's more,
>>> the patch series already in flight removes nfsd_export_wq:
>>
>> Hi Chuck,
>>
>> Apologies, I initially submitted a patch based on the mainline, but I
>> will update it to be based on nfsd-testing later.
>>
>>> https://lore.kernel.org/linux-nfs/98268bb4-2e97-4728-96a6-37b2a4a3ae5d@app.fastmail.com/T/#t
>>>
>>> That patch series replaces the nfsd_export_wq with a WQ that
>>> is managed in sunrpc.ko. Is that incorrect?
>>
>> I'm not sure if I understood you correctly. Do you mean that since this
>> patchset has already removed nfsd_export_wq, I need to adapt more based
>> on this patchset? Or are you saying that replacing nfsd_export_wq with a
>> workqueue in sunrpc.ko might not be sufficient because they are two
>> completely different modules? If you prefer, I can adapt the patch based
>> on this patchset.
>
> It appears to me our fixes conflict with each other. I’m trying to figure
> out which to apply, or if both need to be applied, which order? We do need
> to consider ease of backporting, and your single patch would be easier to
> fit onto LTS kernels.
Yes, this single patch applied first would be easier to fit onto LTS
kernels.
>
> But my series continues to use a WQ to defer resource release for all the
> cache-related files in /proc/fs/nfsd. Is that the wrong solution?
Certainly, as long as it doesn't reintroduce the exportfs-ra-umount
issue, it seems acceptable. However, I would rather avoid doing it. In
fact, as I mentioned earlier in a different discussion, I don't believe
deferring auth_domain_put in ip_map_put is necessary, so setting up a
shared workqueue for cache release callbacks seems unnecessary.
>
>
prev parent reply other threads:[~2026-05-13 1:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 2:33 [PATCH] Revert "NFSD: Defer sub-object cleanup in export put callbacks" Yang Erkun
2026-05-12 11:25 ` Jeff Layton
2026-05-12 12:19 ` yangerkun
2026-05-12 12:30 ` Jeff Layton
2026-05-12 12:36 ` yangerkun
2026-05-12 13:48 ` Chuck Lever
2026-05-13 1:27 ` yangerkun
2026-05-13 1:36 ` Chuck Lever
2026-05-13 1:55 ` yangerkun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56174eb9-d074-4f8e-872b-f13b09813b2c@huaweicloud.com \
--to=yangerkun@huaweicloud.com \
--cc=Dai.Ngo@oracle.com \
--cc=cel@kernel.org \
--cc=chengzhihao1@huawei.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=lilingfeng3@huawei.com \
--cc=linux-nfs@vger.kernel.org \
--cc=misanjum@linux.ibm.com \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).