From: "Chuck Lever" <cel@kernel.org>
To: "Olga Kornievskaia" <aglo@umich.edu>
Cc: "Olga Kornievskaia" <okorniev@redhat.com>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Jeff Layton" <jlayton@kernel.org>,
linux-nfs@vger.kernel.org, neilb@brown.name,
"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>
Subject: Re: [PATCH 2/3] nfsd: update mtime/ctime on synchronous COPY with delegated attributes
Date: Wed, 08 Apr 2026 12:49:52 -0400 [thread overview]
Message-ID: <79484488-0f0b-4ddd-99f6-6ba15373573b@app.fastmail.com> (raw)
In-Reply-To: <CAN-5tyG6JFJ=e9Jkmk0TnzvszWXVneDnDaceA_AOhDtK=ScVog@mail.gmail.com>
On Wed, Apr 8, 2026, at 11:24 AM, Olga Kornievskaia wrote:
> On Wed, Apr 8, 2026 at 9:59 AM Chuck Lever <cel@kernel.org> wrote:
>>
>> On Tue, Apr 7, 2026, at 7:50 PM, Olga Kornievskaia wrote:
>> > COPY should update destination file's mtime/ctime upon completion.
>> >
>> > Signed-off-by: Olga Kornievskaia <okorniev@redhat.com>
>>
>> Should 2/3 also carry a Fixes: tag?
>
> My bad. I guess it should be the same as the first patch. But I now
> also wonder if the update should be done based on the status of
> nfsd4_do_copy? But this is where I think nfsd4_do_copy can return say
> ENOSPC but it would have modified the file as well. So I'm not clear
> if we need to special case return values?
Thinking aloud:
If you updated the time stamps in _nfsd_copy_file_range() wouldn't
that take care of both the sync and async cases, and you could
determine precisely whether a data change had been made to the
destination file?
--
Chuck Lever
next prev parent reply other threads:[~2026-04-08 16:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 23:50 [PATCH 0/3] nfsd update mtime/ctime on CLONE/COPY with delegated attritutes Olga Kornievskaia
2026-04-07 23:50 ` [PATCH 1/3] nfsd: update mtime/ctime on CLONE in presense of delegated attributes Olga Kornievskaia
2026-04-08 13:53 ` Chuck Lever
2026-04-08 15:08 ` Olga Kornievskaia
2026-04-07 23:50 ` [PATCH 2/3] nfsd: update mtime/ctime on synchronous COPY with " Olga Kornievskaia
2026-04-08 13:54 ` Chuck Lever
2026-04-08 15:24 ` Olga Kornievskaia
2026-04-08 16:49 ` Chuck Lever [this message]
2026-04-07 23:50 ` [PATCH 3/3] nfsd: update mtime/ctime on asynchronous " Olga Kornievskaia
2026-04-08 14:05 ` Chuck Lever
2026-04-08 15:43 ` Olga Kornievskaia
2026-04-08 11:13 ` [PATCH 0/3] nfsd update mtime/ctime on CLONE/COPY with delegated attritutes Jeff Layton
2026-04-08 11:17 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79484488-0f0b-4ddd-99f6-6ba15373573b@app.fastmail.com \
--to=cel@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=aglo@umich.edu \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).