From: Sean Chang <seanwascoding@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Chuck Lever <chuck.lever@oracle.com>,
David Laight <david.laight.linux@gmail.com>,
Anna Schumaker <anna@kernel.org>,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] sunrpc/nfs: cleanup redundant debug checks and refactor macros
Date: Sat, 21 Mar 2026 01:43:42 +0800 [thread overview]
Message-ID: <CAAb=EJUQtj08BjbzeovG2dHBfwb5vgza+HdM=ck-bn9n9Ha0BA@mail.gmail.com> (raw)
In-Reply-To: <ab04wi3x3JNVbvPm@black.igk.intel.com>
On Fri, Mar 20, 2026 at 8:08 PM Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
>
> On Thu, Mar 19, 2026 at 10:18:43PM +0800, Sean Chang wrote:
> > This series cleans up redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards
> > across sunrpc, nfsd, and lockd, as these checks are already handled
> > within the dprintk macros.
> >
> > Additionally, it refactors the nfs_errorf() macros into a safer
> > do-while(0) pattern and removes unused nfs_warnf() macros to improve
> > code maintainability.
>
> Shall we also revert the commit ebae102897e7 ("nfsd: Mark variable
> __maybe_unused to avoid W=1 build break") as it seems related to
> dprintk() issues?
>
That's a great catch. I've verified that with the new dprintk() refactoring,
those __maybe_unused attributes are indeed redundant. I will include a
new patch in v4 to remove them and properly credit the cleanup. Thanks!
Best Regards,
Sean
prev parent reply other threads:[~2026-03-20 17:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 14:18 [PATCH v3 0/3] sunrpc/nfs: cleanup redundant debug checks and refactor macros Sean Chang
2026-03-19 14:18 ` [PATCH v3 1/3] nfsd/lockd: Remove redundant debug checks Sean Chang
2026-03-19 14:18 ` [PATCH v3 2/3] svcrdma: remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards Sean Chang
2026-03-19 14:18 ` [PATCH v3 3/3] nfs: refactor nfs_errorf macros and remove unused ones Sean Chang
2026-03-19 14:41 ` Andy Shevchenko
2026-03-19 14:59 ` Sean Chang
2026-03-19 15:49 ` Andy Shevchenko
2026-03-20 17:39 ` Sean Chang
2026-03-20 12:08 ` [PATCH v3 0/3] sunrpc/nfs: cleanup redundant debug checks and refactor macros Andy Shevchenko
2026-03-20 17:43 ` Sean Chang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAb=EJUQtj08BjbzeovG2dHBfwb5vgza+HdM=ck-bn9n9Ha0BA@mail.gmail.com' \
--to=seanwascoding@gmail.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@intel.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).