From: Sean Chang <seanwascoding@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Chuck Lever <chuck.lever@oracle.com>,
David Laight <david.laight.linux@gmail.com>,
Anna Schumaker <anna@kernel.org>,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3 3/3] nfs: refactor nfs_errorf macros and remove unused ones
Date: Sat, 21 Mar 2026 01:39:54 +0800 [thread overview]
Message-ID: <CAAb=EJW-BDmq0yrMu=nGbGN_GsEV6GfZSJPuLz=A+6CdGKhUrQ@mail.gmail.com> (raw)
In-Reply-To: <abwbB-AkHH9Syppw@ashevche-desk.local>
On Thu, Mar 19, 2026 at 11:49 PM Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
>
> > > > #define nfs_invalf(fc, fmt, ...) ((fc)->log.log ? \
> > > > invalf(fc, fmt, ## __VA_ARGS__) : \
> > >
> > > > invalf(fc, fmt, ## __VA_ARGS__) : \
> > > > ({ dfprintk(fac, fmt "\n", ## __VA_ARGS__); -EINVAL; }))
> > >
> > > Why not all of them?
> >
> > I initially only refactored nfs_errorf because it doesn't return a value.
> > For nfs_invalf, it will always return -EINVAL. Would you prefer me to
> > refactor it using the ({ ... }) statement expression pattern to keep the
> > return value, or is it better to leave it as is ?
>
> I don't think in this case it improves the situation. Yeah, it's unfortunate.
>
> > #define nfs_invalf(fc, fmt, ...) ({ \
> > if ((fc)->log.log) \
> > invalf(fc, fmt, ## __VA_ARGS__); \
>
> I believe this already has an error code inside, that's why it's only added to
> the 'else' branch.
>
> > else \
> > dfprintk(fac, fmt "\n", ## __VA_ARGS__);\
> > -EINVAL; \
> > })
>
> Okay, let's go with your original approach (ideally these all probably should
> be replaced by static inline:s).
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Tested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Thanks for your review and for providing the tags!
I'll include your Reviewed-by and Tested-by tags in the v4 submission.
> Unrelated to the series, but if you want to address these:
>
> nfs/super.c:1170:49: warning: incorrect type in initializer (different address spaces)
> nfs/super.c:1170:49: expected struct rpc_xprt *xprt1
> nfs/super.c:1170:49: got struct rpc_xprt [noderef] __rcu *cl_xprt
> nfs/super.c:1171:49: warning: incorrect type in initializer (different address spaces)
> nfs/super.c:1171:49: expected struct rpc_xprt *xprt2
> nfs/super.c:1171:49: got struct rpc_xprt [noderef] __rcu *cl_xprt
>
> nfs/./nfstrace.h:1488:1: warning: dereference of noderef expression
> nfs/./nfs4trace.h:2168:1: error: too long token expansion
> nfs/./nfs4trace.h:2234:1: error: too long token expansion
>
Regarding the Sparse warnings in super.c and the trace header errors,
I've noted them down. I'll look into them separately and may submit a
follow-up patch to address them later.
Best Regards,
Sean
next prev parent reply other threads:[~2026-03-20 17:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 14:18 [PATCH v3 0/3] sunrpc/nfs: cleanup redundant debug checks and refactor macros Sean Chang
2026-03-19 14:18 ` [PATCH v3 1/3] nfsd/lockd: Remove redundant debug checks Sean Chang
2026-03-19 14:18 ` [PATCH v3 2/3] svcrdma: remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards Sean Chang
2026-03-19 14:18 ` [PATCH v3 3/3] nfs: refactor nfs_errorf macros and remove unused ones Sean Chang
2026-03-19 14:41 ` Andy Shevchenko
2026-03-19 14:59 ` Sean Chang
2026-03-19 15:49 ` Andy Shevchenko
2026-03-20 17:39 ` Sean Chang [this message]
2026-03-20 12:08 ` [PATCH v3 0/3] sunrpc/nfs: cleanup redundant debug checks and refactor macros Andy Shevchenko
2026-03-20 17:43 ` Sean Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAb=EJW-BDmq0yrMu=nGbGN_GsEV6GfZSJPuLz=A+6CdGKhUrQ@mail.gmail.com' \
--to=seanwascoding@gmail.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@intel.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).