From: Tushar Sariya <tushar.sariya77@gmail.com>
To: Trond Myklebust <trondmy@kernel.org>, Anna Schumaker <anna@kernel.org>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] NFSv4.1: Apply session size limits on clone path
Date: Sat, 4 Apr 2026 11:56:22 -0230 [thread overview]
Message-ID: <CAG-aSJ-pYZTCuCSQ_LpcvPLb5+gLZHj-z-MaoPLrNfNR+GP5xQ@mail.gmail.com> (raw)
In-Reply-To: <20260404020027.3327248-1-tushar.sariya77@gmail.com>
Superseded. Reposting as a reply to the original regression report:
https://lore.kernel.org/all/177349021750.3039212.10211295677877269201@eldamar.lan/
On Fri, Apr 3, 2026 at 11:30 PM Tushar Sariya <tushar.sariya77@gmail.com> wrote:
>
> From: Tushar Sariya <tushar.97@hotmail.com>
>
> The NFS automount clone path (nfs4_clone_server) is missing the
> session-size clamping that top-level mounts get in
> nfs4_server_common_setup(). This was exposed by 2b092175f5e3 which
> changed submounts to no longer unconditionally inherit the parent's
> already-clamped rsize/wsize. On servers that enforce tight
> max_request_size budgets (reported on Dell EMC Isilon/OneFS), the
> child mount ends up with raw unclamped values that exceed the session
> channel limits, resulting in NFS4ERR_REQ_TOO_BIG and user-visible EIO.
>
> Note: I was unable to reproduce the exact failure locally as it appears
> to require a server that enforces tight max_request_size budgets. The
> fix is based on code analysis — the clone path is missing the same
> session-limit clamping that top-level mounts apply in
> nfs4_server_common_setup(). Tested that the kernel builds and boots
> successfully.
>
> Tushar Sariya (1):
> NFSv4.1: Apply session size limits on clone path
>
> fs/nfs/internal.h | 2 ++
> fs/nfs/nfs4client.c | 4 ++--
> fs/nfs/nfs4proc.c | 3 +++
> 3 files changed, 7 insertions(+), 2 deletions(-)
>
> --
> 2.43.0
>
prev parent reply other threads:[~2026-04-04 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 2:00 [PATCH 0/1] NFSv4.1: Apply session size limits on clone path Tushar Sariya
2026-04-04 2:00 ` [PATCH 1/1] " Tushar Sariya
2026-04-04 14:26 ` Tushar Sariya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG-aSJ-pYZTCuCSQ_LpcvPLb5+gLZHj-z-MaoPLrNfNR+GP5xQ@mail.gmail.com \
--to=tushar.sariya77@gmail.com \
--cc=anna@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).