From: Steve French <smfrench@gmail.com>
To: Chuck Lever <cel@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-api@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
hirofumi@mail.parknet.co.jp, linkinjeon@kernel.org,
sj1557.seo@samsung.com, yuezhang.mo@sony.com,
almaz.alexandrovich@paragon-software.com, slava@dubeyko.com,
glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu,
adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org,
pc@manguebit.org, ronniesahlberg@gmail.com,
sprasad@microsoft.com, trondmy@kernel.org, anna@kernel.org,
jaegeuk@kernel.org, chao@kernel.org, hansg@kernel.org,
senozhatsky@chromium.org, Chuck Lever <chuck.lever@oracle.com>,
Steve French <stfrench@microsoft.com>
Subject: Re: [PATCH v10 10/17] cifs: Implement fileattr_get for case sensitivity
Date: Thu, 23 Apr 2026 16:02:56 -0500 [thread overview]
Message-ID: <CAH2r5mu1Wg_9tZCjei-xF357UjKR+h6jQr9zey39v59rx9quZQ@mail.gmail.com> (raw)
In-Reply-To: <20260423-case-sensitivity-v10-10-c385d674a6cf@oracle.com>
Should this also be checking if the SMB3.1.1 Linux Extensions or SMB
POSIX Extensions are negotiated (ie the server supports case
sensitivity)?
On Thu, Apr 23, 2026 at 8:20 AM Chuck Lever <cel@kernel.org> wrote:
>
> From: Chuck Lever <chuck.lever@oracle.com>
>
> Upper layers such as NFSD need a way to query whether a filesystem
> handles filenames in a case-sensitive manner. Report CIFS/SMB case
> handling behavior via the FS_XFLAG_CASEFOLD flag.
>
> CIFS servers (typically Windows or Samba) are usually case-insensitive
> but case-preserving, meaning they ignore case during lookups but store
> filenames exactly as provided.
>
> The implementation reports case sensitivity based on the nocase mount
> option, which reflects whether the client expects the server to perform
> case-insensitive comparisons. When nocase is set, the mount is reported
> as case-insensitive.
>
> The callback is registered in all three inode_operations structures
> (directory, file, and symlink) to ensure consistent reporting across
> all inode types.
>
> Acked-by: Steve French <stfrench@microsoft.com>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/smb/client/cifsfs.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
> index 2025739f070a..9b70ffa3e01d 100644
> --- a/fs/smb/client/cifsfs.c
> +++ b/fs/smb/client/cifsfs.c
> @@ -30,6 +30,7 @@
> #include <linux/xattr.h>
> #include <linux/mm.h>
> #include <linux/key-type.h>
> +#include <linux/fileattr.h>
> #include <uapi/linux/magic.h>
> #include <net/ipv6.h>
> #include "cifsfs.h"
> @@ -1199,6 +1200,22 @@ struct file_system_type smb3_fs_type = {
> MODULE_ALIAS_FS("smb3");
> MODULE_ALIAS("smb3");
>
> +static int cifs_fileattr_get(struct dentry *dentry, struct file_kattr *fa)
> +{
> + struct cifs_sb_info *cifs_sb = CIFS_SB(dentry->d_sb);
> + struct cifs_tcon *tcon = cifs_sb_master_tcon(cifs_sb);
> +
> + /*
> + * The nocase mount option installs case-insensitive dentry
> + * operations on this superblock. SMB preserves case on the
> + * wire and at rest, so the mount matches FS_XFLAG_CASEFOLD
> + * semantics: case-folded lookup, verbatim storage.
> + */
> + if (tcon->nocase)
> + fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
> + return 0;
> +}
> +
> const struct inode_operations cifs_dir_inode_ops = {
> .create = cifs_create,
> .atomic_open = cifs_atomic_open,
> @@ -1217,6 +1234,7 @@ const struct inode_operations cifs_dir_inode_ops = {
> .listxattr = cifs_listxattr,
> .get_acl = cifs_get_acl,
> .set_acl = cifs_set_acl,
> + .fileattr_get = cifs_fileattr_get,
> };
>
> const struct inode_operations cifs_file_inode_ops = {
> @@ -1227,6 +1245,7 @@ const struct inode_operations cifs_file_inode_ops = {
> .fiemap = cifs_fiemap,
> .get_acl = cifs_get_acl,
> .set_acl = cifs_set_acl,
> + .fileattr_get = cifs_fileattr_get,
> };
>
> const char *cifs_get_link(struct dentry *dentry, struct inode *inode,
> @@ -1261,6 +1280,7 @@ const struct inode_operations cifs_symlink_inode_ops = {
> .setattr = cifs_setattr,
> .permission = cifs_permission,
> .listxattr = cifs_listxattr,
> + .fileattr_get = cifs_fileattr_get,
> };
>
> /*
>
> --
> 2.53.0
>
>
--
Thanks,
Steve
next prev parent reply other threads:[~2026-04-23 21:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 13:12 [PATCH v10 00/17] Exposing case folding behavior Chuck Lever
2026-04-23 13:12 ` [PATCH v10 01/17] fs: Move file_kattr initialization to callers Chuck Lever
2026-04-23 13:12 ` [PATCH v10 02/17] fs: Add case sensitivity flags to file_kattr Chuck Lever
2026-04-23 13:12 ` [PATCH v10 03/17] fat: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-23 13:12 ` [PATCH v10 04/17] exfat: " Chuck Lever
2026-04-23 13:12 ` [PATCH v10 05/17] ntfs3: " Chuck Lever
2026-04-23 13:12 ` [PATCH v10 06/17] hfs: " Chuck Lever
2026-04-23 13:12 ` [PATCH v10 07/17] hfsplus: Report case sensitivity in fileattr_get Chuck Lever
2026-04-23 13:12 ` [PATCH v10 08/17] ext4: " Chuck Lever
2026-04-23 13:12 ` [PATCH v10 09/17] xfs: " Chuck Lever
2026-04-23 13:12 ` [PATCH v10 10/17] cifs: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-23 21:02 ` Steve French [this message]
2026-04-23 13:12 ` [PATCH v10 11/17] nfs: " Chuck Lever
2026-04-23 13:12 ` [PATCH v10 12/17] f2fs: Add case sensitivity reporting to fileattr_get Chuck Lever
2026-04-23 13:12 ` [PATCH v10 13/17] vboxsf: Implement fileattr_get for case sensitivity Chuck Lever
2026-04-23 13:12 ` [PATCH v10 14/17] isofs: " Chuck Lever
2026-04-23 13:12 ` [PATCH v10 15/17] nfsd: Report export case-folding via NFSv3 PATHCONF Chuck Lever
2026-04-23 13:12 ` [PATCH v10 16/17] nfsd: Implement NFSv4 FATTR4_CASE_INSENSITIVE and FATTR4_CASE_PRESERVING Chuck Lever
2026-04-23 13:12 ` [PATCH v10 17/17] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION Chuck Lever
2026-04-23 14:39 ` [PATCH v10 00/17] Exposing case folding behavior Roland Mainz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5mu1Wg_9tZCjei-xF357UjKR+h6jQr9zey39v59rx9quZQ@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=anna@kernel.org \
--cc=brauner@kernel.org \
--cc=cel@kernel.org \
--cc=cem@kernel.org \
--cc=chao@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hansg@kernel.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=sj1557.seo@samsung.com \
--cc=slava@dubeyko.com \
--cc=sprasad@microsoft.com \
--cc=stfrench@microsoft.com \
--cc=trondmy@kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yuezhang.mo@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).