linux-numa.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Andy Whitcroft <apw@canonical.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm <linux-mm@kvack.org>, Mel Gorman <mel@csn.ul.ie>,
	Nishanth Aravamudan <nacc@us.ibm.com>,
	David Rientjes <rientjes@google.com>, Adam Litke <agl@us.ibm.com>,
	Eric Whitney <eric.whitney@hp.com>,
	linux-numa <linux-numa@vger.kernel.org>
Subject: Re: [PATCH] hugetlb:  restore interleaving of bootmem huge pages
Date: Thu, 16 Jul 2009 20:17:45 +0200	[thread overview]
Message-ID: <20090716181745.GF8046@one.firstfloor.org> (raw)
In-Reply-To: <20090716173158.GB9507@shadowen.org>

> It looks like this behaviour was in the original implementation to my eye.
> It does indeed seem to prefer taking all it can from one node before moving
> on to the next.  Your change seems reasonable to my eye though it may be
> worth asking Andi if it was intended.  The intent of this change seems
> to bring the behaviour into line with that of alloc_fresh_huge_page()
> used for orders less than MAX_ORDER.

I don't remember intending it this way. The intention was always
standard round robin one by one. If it didn't do that it wasn't extended.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2009-07-16 18:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 14:31 [PATCH] hugetlb: restore interleaving of bootmem huge pages Lee Schermerhorn
2009-07-16 14:51 ` Mel Gorman
2009-07-16 17:31 ` Andy Whitcroft
2009-07-16 18:17   ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090716181745.GF8046@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=agl@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=eric.whitney@hp.com \
    --cc=linux-mm@kvack.org \
    --cc=linux-numa@vger.kernel.org \
    --cc=mel@csn.ul.ie \
    --cc=nacc@us.ibm.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).