From: Daniel Wagner <dwagner@suse.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org, gjoyce@ibm.com
Subject: Re: [PATCH nvme-cli] nvme : Don't seg fault if given device is not char/block device
Date: Wed, 20 Mar 2024 08:16:21 +0100 [thread overview]
Message-ID: <doqj5ci7aokhxugwu5jul7h6scnl4dt5cukq3gkj7tput5fn5o@f72afjmdejx4> (raw)
In-Reply-To: <20240317113758.3055071-1-nilay@linux.ibm.com>
On Sun, Mar 17, 2024 at 05:06:22PM +0530, Nilay Shroff wrote:
> If the given device name is not char/block device then in
> open_dev_direct() set errno to ENODEV and err to -1 before
> returning to the dev_fd(). This would then ensure that in
> case of error, dev_fd() returns the corerct negative error
> code back to its callers. So now the callers of dev_fd()
> would handle the error appropriately instead of try
> accessing the nvme_dev which would be NULL.
>
> Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
Patch applied. Thanks.
prev parent reply other threads:[~2024-03-20 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 11:36 [PATCH nvme-cli] nvme : Don't seg fault if given device is not char/block device Nilay Shroff
2024-03-20 7:16 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=doqj5ci7aokhxugwu5jul7h6scnl4dt5cukq3gkj7tput5fn5o@f72afjmdejx4 \
--to=dwagner@suse.de \
--cc=gjoyce@ibm.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).