From: Daniel Wagner <dwagner@suse.de>
To: Israel Rukshin <israelr@nvidia.com>
Cc: Max Gurtovoy <mgurtovoy@nvidia.com>,
Linux-nvme <linux-nvme@lists.infradead.org>,
Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] libnvme: Introduce nvmf_hostid_generate function
Date: Wed, 17 Apr 2024 09:47:54 +0200 [thread overview]
Message-ID: <okgtxgle6kqk65azqfx27tlkkpsbn5dbvbkesirw4quiwvvwzm@6lvwpmtisj2k> (raw)
In-Reply-To: <1713249176-7837-2-git-send-email-israelr@nvidia.com>
On Tue, Apr 16, 2024 at 06:32:56AM +0000, Israel Rukshin wrote:
> /**
> * nvmf_hostnqn_generate() - Generate a machine specific host nqn
> - * Returns: An nvm namespace qualified name string based on the machine
> - * identifier, or NULL if not successful.
> + * @hostid: Host identifier
> + *
> + * If @hostid is NULL, the function generates it based on the machine
> + * identifier.
> + *
> + * Return: On success, an NVMe Qualified Name for host identification. This
> + * name is based on the given host identifier. On failure, NULL.
> + */
> +char *nvmf_hostnqn_generate(char *hostid);
This breaks the API. The only way around this is to introduce a complete
new function as far I know.
next prev parent reply other threads:[~2024-04-17 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 6:32 [PATCH] fabrics: Always pass hostid and hostnqn Israel Rukshin
2024-04-16 6:32 ` [PATCH] libnvme: Introduce nvmf_hostid_generate function Israel Rukshin
2024-04-17 7:47 ` Daniel Wagner [this message]
2024-04-17 7:43 ` [PATCH] fabrics: Always pass hostid and hostnqn Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=okgtxgle6kqk65azqfx27tlkkpsbn5dbvbkesirw4quiwvvwzm@6lvwpmtisj2k \
--to=dwagner@suse.de \
--cc=hch@lst.de \
--cc=israelr@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).