* [PATCH 1/6] dt-bindings: mfd: ti,twl: Document system-power-controller
2023-11-25 9:29 [PATCH 0/6] mfd: twl: system-power-controller Andreas Kemnade
@ 2023-11-25 9:29 ` Andreas Kemnade
2023-11-25 11:46 ` Conor Dooley
2023-11-25 9:29 ` [PATCH 2/6] twl-core: add power off implementation for twl603x Andreas Kemnade
` (4 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Andreas Kemnade @ 2023-11-25 9:29 UTC (permalink / raw
To: lee, robh+dt, krzysztof.kozlowski+dt, conor+dt, bcousson, tony,
andreas, devicetree, linux-kernel, linux-omap
Add system-power-controller property because these chips
can power off the device.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Documentation/devicetree/bindings/mfd/ti,twl.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
index c04d57ba22b49..52ed228fb1e7e 100644
--- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
@@ -34,6 +34,8 @@ properties:
interrupt-controller: true
+ system-power-controller: true
+
"#interrupt-cells":
const: 1
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 1/6] dt-bindings: mfd: ti,twl: Document system-power-controller
2023-11-25 9:29 ` [PATCH 1/6] dt-bindings: mfd: ti,twl: Document system-power-controller Andreas Kemnade
@ 2023-11-25 11:46 ` Conor Dooley
0 siblings, 0 replies; 11+ messages in thread
From: Conor Dooley @ 2023-11-25 11:46 UTC (permalink / raw
To: Andreas Kemnade
Cc: lee, robh+dt, krzysztof.kozlowski+dt, conor+dt, bcousson, tony,
devicetree, linux-kernel, linux-omap
[-- Attachment #1: Type: text/plain, Size: 290 bytes --]
On Sat, Nov 25, 2023 at 10:29:33AM +0100, Andreas Kemnade wrote:
> Add system-power-controller property because these chips
> can power off the device.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/6] twl-core: add power off implementation for twl603x
2023-11-25 9:29 [PATCH 0/6] mfd: twl: system-power-controller Andreas Kemnade
2023-11-25 9:29 ` [PATCH 1/6] dt-bindings: mfd: ti,twl: Document system-power-controller Andreas Kemnade
@ 2023-11-25 9:29 ` Andreas Kemnade
2023-11-25 15:13 ` kernel test robot
` (2 more replies)
2023-11-25 9:29 ` [PATCH 3/6] ARM: dts: omap-embt2ws: system-power-controller for bt200 Andreas Kemnade
` (3 subsequent siblings)
5 siblings, 3 replies; 11+ messages in thread
From: Andreas Kemnade @ 2023-11-25 9:29 UTC (permalink / raw
To: lee, robh+dt, krzysztof.kozlowski+dt, conor+dt, bcousson, tony,
andreas, devicetree, linux-kernel, linux-omap
If the system-power-controller property is there, enable power off.
Implementation is based on a Linux v3.0 vendor kernel.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
drivers/mfd/twl-core.c | 34 ++++++++++++++++++++++++++++++++++
include/linux/mfd/twl.h | 1 +
2 files changed, 35 insertions(+)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 6e384a79e3418..3eef285eac535 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -687,6 +687,31 @@ static void twl_remove(struct i2c_client *client)
twl_priv->ready = false;
}
+void twl6030_power_off(void)
+{
+#define APP_DEVOFF (1<<0)
+#define CON_DEVOFF (1<<1)
+#define MOD_DEVOFF (1<<2)
+
+ int err;
+ u8 val;
+
+ err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val,
+ TWL6030_PHOENIX_DEV_ON);
+ if (err) {
+ pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err);
+ return;
+ }
+
+ val |= APP_DEVOFF | CON_DEVOFF | MOD_DEVOFF;
+
+ err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val,
+ TWL6030_PHOENIX_DEV_ON);
+ if (err)
+ pr_err("TWL6030 Unable to power off\n");
+}
+
+
static struct of_dev_auxdata twl_auxdata_lookup[] = {
OF_DEV_AUXDATA("ti,twl4030-gpio", 0, "twl4030-gpio", NULL),
{ /* sentinel */ },
@@ -852,6 +877,15 @@ twl_probe(struct i2c_client *client)
goto free;
}
+ if (twl_class_is_6030()) {
+ if (of_device_is_system_power_controller(client->dev.of_node)) {
+ if (!pm_power_off)
+ pm_power_off = twl6030_power_off;
+ else
+ dev_warn(&client->dev, "Poweroff callback already assigned\n");
+ }
+ }
+
status = of_platform_populate(node, NULL, twl_auxdata_lookup,
&client->dev);
diff --git a/include/linux/mfd/twl.h b/include/linux/mfd/twl.h
index c062d91a67d92..85dc406173dba 100644
--- a/include/linux/mfd/twl.h
+++ b/include/linux/mfd/twl.h
@@ -461,6 +461,7 @@ static inline int twl6030_mmc_card_detect(struct device *dev, int slot)
#define TWL4030_PM_MASTER_GLOBAL_TST 0xb6
+#define TWL6030_PHOENIX_DEV_ON 0x06
/*----------------------------------------------------------------------*/
/* Power bus message definitions */
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 2/6] twl-core: add power off implementation for twl603x
2023-11-25 9:29 ` [PATCH 2/6] twl-core: add power off implementation for twl603x Andreas Kemnade
@ 2023-11-25 15:13 ` kernel test robot
2023-11-25 20:00 ` kernel test robot
2023-11-26 23:32 ` kernel test robot
2 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2023-11-25 15:13 UTC (permalink / raw
To: Andreas Kemnade, lee, robh+dt, krzysztof.kozlowski+dt, conor+dt,
bcousson, tony, devicetree, linux-kernel, linux-omap
Cc: oe-kbuild-all
Hi Andreas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on lee-mfd/for-mfd-next linus/master v6.7-rc2 next-20231124]
[cannot apply to tmlind-omap/for-next lee-mfd/for-mfd-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Kemnade/dt-bindings-mfd-ti-twl-Document-system-power-controller/20231125-173426
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20231125092938.16535-3-andreas%40kemnade.info
patch subject: [PATCH 2/6] twl-core: add power off implementation for twl603x
config: xtensa-randconfig-r081-20231125 (https://download.01.org/0day-ci/archive/20231125/202311252254.j0JQBIvl-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231125/202311252254.j0JQBIvl-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311252254.j0JQBIvl-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/mfd/twl-core.c:690:6: warning: no previous prototype for 'twl6030_power_off' [-Wmissing-prototypes]
690 | void twl6030_power_off(void)
| ^~~~~~~~~~~~~~~~~
vim +/twl6030_power_off +690 drivers/mfd/twl-core.c
689
> 690 void twl6030_power_off(void)
691 {
692 #define APP_DEVOFF (1<<0)
693 #define CON_DEVOFF (1<<1)
694 #define MOD_DEVOFF (1<<2)
695
696 int err;
697 u8 val;
698
699 err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val,
700 TWL6030_PHOENIX_DEV_ON);
701 if (err) {
702 pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err);
703 return;
704 }
705
706 val |= APP_DEVOFF | CON_DEVOFF | MOD_DEVOFF;
707
708 err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val,
709 TWL6030_PHOENIX_DEV_ON);
710 if (err)
711 pr_err("TWL6030 Unable to power off\n");
712 }
713
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 2/6] twl-core: add power off implementation for twl603x
2023-11-25 9:29 ` [PATCH 2/6] twl-core: add power off implementation for twl603x Andreas Kemnade
2023-11-25 15:13 ` kernel test robot
@ 2023-11-25 20:00 ` kernel test robot
2023-11-26 23:32 ` kernel test robot
2 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2023-11-25 20:00 UTC (permalink / raw
To: Andreas Kemnade, lee, robh+dt, krzysztof.kozlowski+dt, conor+dt,
bcousson, tony, devicetree, linux-kernel, linux-omap
Cc: llvm, oe-kbuild-all
Hi Andreas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on lee-mfd/for-mfd-next linus/master v6.7-rc2 next-20231124]
[cannot apply to tmlind-omap/for-next lee-mfd/for-mfd-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Kemnade/dt-bindings-mfd-ti-twl-Document-system-power-controller/20231125-173426
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20231125092938.16535-3-andreas%40kemnade.info
patch subject: [PATCH 2/6] twl-core: add power off implementation for twl603x
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231126/202311260213.vq3gMAgF-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231126/202311260213.vq3gMAgF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311260213.vq3gMAgF-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/mfd/twl-core.c:690:6: warning: no previous prototype for function 'twl6030_power_off' [-Wmissing-prototypes]
void twl6030_power_off(void)
^
drivers/mfd/twl-core.c:690:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void twl6030_power_off(void)
^
static
1 warning generated.
vim +/twl6030_power_off +690 drivers/mfd/twl-core.c
689
> 690 void twl6030_power_off(void)
691 {
692 #define APP_DEVOFF (1<<0)
693 #define CON_DEVOFF (1<<1)
694 #define MOD_DEVOFF (1<<2)
695
696 int err;
697 u8 val;
698
699 err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val,
700 TWL6030_PHOENIX_DEV_ON);
701 if (err) {
702 pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err);
703 return;
704 }
705
706 val |= APP_DEVOFF | CON_DEVOFF | MOD_DEVOFF;
707
708 err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val,
709 TWL6030_PHOENIX_DEV_ON);
710 if (err)
711 pr_err("TWL6030 Unable to power off\n");
712 }
713
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 2/6] twl-core: add power off implementation for twl603x
2023-11-25 9:29 ` [PATCH 2/6] twl-core: add power off implementation for twl603x Andreas Kemnade
2023-11-25 15:13 ` kernel test robot
2023-11-25 20:00 ` kernel test robot
@ 2023-11-26 23:32 ` kernel test robot
2 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2023-11-26 23:32 UTC (permalink / raw
To: Andreas Kemnade, lee, robh+dt, krzysztof.kozlowski+dt, conor+dt,
bcousson, tony, devicetree, linux-kernel, linux-omap
Cc: oe-kbuild-all
Hi Andreas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on lee-mfd/for-mfd-next linus/master v6.7-rc2 next-20231124]
[cannot apply to tmlind-omap/for-next lee-mfd/for-mfd-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Kemnade/dt-bindings-mfd-ti-twl-Document-system-power-controller/20231125-173426
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20231125092938.16535-3-andreas%40kemnade.info
patch subject: [PATCH 2/6] twl-core: add power off implementation for twl603x
config: x86_64-randconfig-122-20231126 (https://download.01.org/0day-ci/archive/20231127/202311270558.j38P20an-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231127/202311270558.j38P20an-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311270558.j38P20an-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/mfd/twl-core.c:690:6: sparse: sparse: symbol 'twl6030_power_off' was not declared. Should it be static?
vim +/twl6030_power_off +690 drivers/mfd/twl-core.c
689
> 690 void twl6030_power_off(void)
691 {
692 #define APP_DEVOFF (1<<0)
693 #define CON_DEVOFF (1<<1)
694 #define MOD_DEVOFF (1<<2)
695
696 int err;
697 u8 val;
698
699 err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val,
700 TWL6030_PHOENIX_DEV_ON);
701 if (err) {
702 pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err);
703 return;
704 }
705
706 val |= APP_DEVOFF | CON_DEVOFF | MOD_DEVOFF;
707
708 err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val,
709 TWL6030_PHOENIX_DEV_ON);
710 if (err)
711 pr_err("TWL6030 Unable to power off\n");
712 }
713
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/6] ARM: dts: omap-embt2ws: system-power-controller for bt200
2023-11-25 9:29 [PATCH 0/6] mfd: twl: system-power-controller Andreas Kemnade
2023-11-25 9:29 ` [PATCH 1/6] dt-bindings: mfd: ti,twl: Document system-power-controller Andreas Kemnade
2023-11-25 9:29 ` [PATCH 2/6] twl-core: add power off implementation for twl603x Andreas Kemnade
@ 2023-11-25 9:29 ` Andreas Kemnade
2023-11-25 9:29 ` [PATCH 4/6] ARM: dts: omap4-panda-common: Enable powering off the device Andreas Kemnade
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Andreas Kemnade @ 2023-11-25 9:29 UTC (permalink / raw
To: lee, robh+dt, krzysztof.kozlowski+dt, conor+dt, bcousson, tony,
andreas, devicetree, linux-kernel, linux-omap
Configure the TWL6032 as system power controller to let the device
power off.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
index 4e267b259ebf0..bb2e9544723c3 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
+++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
@@ -215,6 +215,7 @@ twl: pmic@48 {
interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to gic */
interrupt-controller;
#interrupt-cells = <1>;
+ system-power-controller;
rtc {
compatible = "ti,twl4030-rtc";
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 4/6] ARM: dts: omap4-panda-common: Enable powering off the device
2023-11-25 9:29 [PATCH 0/6] mfd: twl: system-power-controller Andreas Kemnade
` (2 preceding siblings ...)
2023-11-25 9:29 ` [PATCH 3/6] ARM: dts: omap-embt2ws: system-power-controller for bt200 Andreas Kemnade
@ 2023-11-25 9:29 ` Andreas Kemnade
2023-11-25 9:29 ` [PATCH 5/6] mfd: twl4030-power: accept standard property for power controller Andreas Kemnade
2023-11-25 9:29 ` [PATCH 6/6] ARM: dts: omap: gta04: standardize system-power-controller Andreas Kemnade
5 siblings, 0 replies; 11+ messages in thread
From: Andreas Kemnade @ 2023-11-25 9:29 UTC (permalink / raw
To: lee, robh+dt, krzysztof.kozlowski+dt, conor+dt, bcousson, tony,
andreas, devicetree, linux-kernel, linux-omap
As the TWL6030 chip is the main power controller here, declare
it as system-power-controller
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
index f528511c2537b..97706d6296a68 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
+++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
@@ -408,6 +408,7 @@ twl: twl@48 {
reg = <0x48>;
/* IRQ# = 7 */
interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to gic */
+ system-power-controller;
};
twl6040: twl@4b {
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5/6] mfd: twl4030-power: accept standard property for power controller
2023-11-25 9:29 [PATCH 0/6] mfd: twl: system-power-controller Andreas Kemnade
` (3 preceding siblings ...)
2023-11-25 9:29 ` [PATCH 4/6] ARM: dts: omap4-panda-common: Enable powering off the device Andreas Kemnade
@ 2023-11-25 9:29 ` Andreas Kemnade
2023-11-25 9:29 ` [PATCH 6/6] ARM: dts: omap: gta04: standardize system-power-controller Andreas Kemnade
5 siblings, 0 replies; 11+ messages in thread
From: Andreas Kemnade @ 2023-11-25 9:29 UTC (permalink / raw
To: lee, robh+dt, krzysztof.kozlowski+dt, conor+dt, bcousson, tony,
andreas, devicetree, linux-kernel, linux-omap
Instead of only accepting the ti specific properties accept also
the standard property. For uniformity, search in the parent node
for the tag. The code for powering of is also isolated from the
rest in this file. So it is a pure Linux design decision to put it
here.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
drivers/mfd/twl4030-power.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index e35b0f788c504..3ef892e63b88f 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -686,6 +686,9 @@ static bool twl4030_power_use_poweroff(const struct twl4030_power_data *pdata,
if (of_property_read_bool(node, "ti,use_poweroff"))
return true;
+ if (of_device_is_system_power_controller(node->parent))
+ return true;
+
return false;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 6/6] ARM: dts: omap: gta04: standardize system-power-controller
2023-11-25 9:29 [PATCH 0/6] mfd: twl: system-power-controller Andreas Kemnade
` (4 preceding siblings ...)
2023-11-25 9:29 ` [PATCH 5/6] mfd: twl4030-power: accept standard property for power controller Andreas Kemnade
@ 2023-11-25 9:29 ` Andreas Kemnade
5 siblings, 0 replies; 11+ messages in thread
From: Andreas Kemnade @ 2023-11-25 9:29 UTC (permalink / raw
To: lee, robh+dt, krzysztof.kozlowski+dt, conor+dt, bcousson, tony,
andreas, devicetree, linux-kernel, linux-omap
Replace TI-specific property by generic one.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
cannot be applied independently of the other ones, so maybe simply delay
it.
arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
index 3661340009e7a..5001c4ea35658 100644
--- a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
@@ -476,6 +476,7 @@ twl: twl@48 {
reg = <0x48>;
interrupts = <7>; /* SYS_NIRQ cascaded to intc */
interrupt-parent = <&intc>;
+ system-power-controller;
clocks = <&hfclk_26m>;
clock-names = "fck";
@@ -490,7 +491,6 @@ codec {
twl_power: power {
compatible = "ti,twl4030-power-idle";
- ti,system-power-controller;
};
};
};
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread