From: Markus Elfring <Markus.Elfring@web.de>
To: linux-omap@vger.kernel.org, kernel-janitors@vger.kernel.org,
Tony Lindgren <tony@atomide.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] bus: omap_l3_noc: Use devm_platform_ioremap_resource() in omap_l3_probe()
Date: Tue, 6 Feb 2024 17:08:30 +0100 [thread overview]
Message-ID: <59412fc9-396d-4b62-95a8-1aed3d61cd0c@web.de> (raw)
In-Reply-To: <10028785-166f-4473-900a-c845cb690dc8@web.de>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 6 Feb 2024 17:01:25 +0100
A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42
("drivers: provide devm_platform_ioremap_resource()").
* Thus reuse existing functionality instead of keeping duplicate source code.
* Delete a local variable which became unnecessary with this refactoring.
This issue was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
v2:
The transformation pattern was adjusted based on advices by known contributors.
Examples:
* Doug Anderson
* Geert Uytterhoeven
* Robin Murphy
drivers/bus/omap_l3_noc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
index eb1ba6319fda..f114dee4e937 100644
--- a/drivers/bus/omap_l3_noc.c
+++ b/drivers/bus/omap_l3_noc.c
@@ -255,16 +255,14 @@ static int omap_l3_probe(struct platform_device *pdev)
/* Get mem resources */
for (i = 0, res_idx = 0; i < l3->num_modules; i++) {
- struct resource *res;
-
if (l3->l3_base[i] == L3_BASE_IS_SUBMODULE) {
/* First entry cannot be submodule */
BUG_ON(i == 0);
l3->l3_base[i] = l3->l3_base[i - 1];
continue;
}
- res = platform_get_resource(pdev, IORESOURCE_MEM, res_idx);
- l3->l3_base[i] = devm_ioremap_resource(&pdev->dev, res);
+
+ l3->l3_base[i] = devm_platform_ioremap_resource(pdev, res_idx);
if (IS_ERR(l3->l3_base[i])) {
dev_err(l3->dev, "ioremap %d failed\n", i);
return PTR_ERR(l3->l3_base[i]);
--
2.43.0
prev parent reply other threads:[~2024-02-06 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 6:40 [PATCH] bus: omap_l3_noc: Use devm_platform_get_and_ioremap_resource() in omap_l3_probe() Markus Elfring
2024-02-06 16:08 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59412fc9-396d-4b62-95a8-1aed3d61cd0c@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).