From: Andrew Davis <afd@ti.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>,
<linux-omap@vger.kernel.org>, <linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] hwspinlock: omap: Use devm_pm_runtime_enable() helper
Date: Tue, 6 Feb 2024 13:07:28 -0600 [thread overview]
Message-ID: <a225205a-0baf-493e-9138-91aac7e0371b@ti.com> (raw)
In-Reply-To: <73jxbyqatxc7r56df2iweewb22qvmqo33rhpsu3darczn7ldof@p2qepqpdf5ds>
On 2/6/24 1:06 PM, Bjorn Andersson wrote:
> On Tue, Jan 23, 2024 at 10:04:03AM -0600, Andrew Davis wrote:
>> This disables runtime PM on module exit, allowing us to simplify
>> the probe exit path and remove callbacks. Do that here.
>
> As with the later patch, unless I'm misreading the code, you already do
> disable runtime PM in omap_hwspinlock_remove().
>
Right, what I meant to say in the commit message was
"This disables runtime PM on module exit *automatically for us*.."
As in we don't have to manually do it anymore, and that simplifies
the code, which is the "fix" that this patch does.
Will update the commit message to make that more clear in this
and the next patch.
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>> drivers/hwspinlock/omap_hwspinlock.c | 26 ++++++++------------------
>> 1 file changed, 8 insertions(+), 18 deletions(-)
>>
>> diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c
> [..]
>> @@ -129,16 +125,12 @@ static int omap_hwspinlock_probe(struct platform_device *pdev)
>> ret = hwspin_lock_register(bank, &pdev->dev, &omap_hwspinlock_ops,
>> base_id, num_locks);
>> if (ret)
>> - goto runtime_err;
>> + return ret;
>>
>> dev_dbg(&pdev->dev, "Registered %d locks with HwSpinlock core\n",
>> num_locks);
>
> I don't fancy these debug information messages, there are other ways to
> confirm that the device probed successfully etc.
>
> Now that you don't need the goto runtime_err, I'd prefer the tail of
> this function:
>
> return hwspin_lock_register(...);
>
Sure, will update.
Thanks,
Andrew
> Regards,
> Bjorn
>
>>
>> return 0;
>> -
>> -runtime_err:
>> - pm_runtime_disable(&pdev->dev);
>> - return ret;
>> }
>>
>> static void omap_hwspinlock_remove(struct platform_device *pdev)
>> @@ -151,8 +143,6 @@ static void omap_hwspinlock_remove(struct platform_device *pdev)
>> dev_err(&pdev->dev, "%s failed: %d\n", __func__, ret);
>> return;
>> }
>> -
>> - pm_runtime_disable(&pdev->dev);
>> }
>>
>> static const struct of_device_id omap_hwspinlock_of_match[] = {
>> --
>> 2.39.2
>>
next prev parent reply other threads:[~2024-02-06 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 16:04 [PATCH 1/4] hwspinlock: omap: Remove unneeded check for OF node Andrew Davis
2024-01-23 16:04 ` [PATCH 2/4] hwspinlock: omap: Use devm_pm_runtime_enable() helper Andrew Davis
2024-02-06 19:06 ` Bjorn Andersson
2024-02-06 19:07 ` Andrew Davis [this message]
2024-01-23 16:04 ` [PATCH 3/4] hwspinlock: omap: Use devm_hwspin_lock_register() helper Andrew Davis
2024-02-06 19:02 ` Bjorn Andersson
2024-01-23 16:04 ` [PATCH 4/4] hwspinlock: omap: Use index to get hwspinlock pointer Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a225205a-0baf-493e-9138-91aac7e0371b@ti.com \
--to=afd@ti.com \
--cc=andersson@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).