From: Maxime Ripard <mripard@kernel.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Andrew Davis" <afd@ti.com>,
"Frank Binns" <frank.binns@imgtec.com>,
"Donald Robson" <donald.robson@imgtec.com>,
"Matt Coster" <matt.coster@imgtec.com>,
"Adam Ford" <aford173@gmail.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>, "Nishanth Menon" <nm@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Tero Kristo" <kristo@kernel.org>,
"Paul Cercueil" <paul@crapouillou.net>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: Re: [PATCH RFC v2 04/11] ARM: dts: omap4: Add device tree entry for SGX GPU
Date: Mon, 15 Jan 2024 15:45:37 +0100 [thread overview]
Message-ID: <xagwa5cie5gjzidg5wa6ou3yd2qwta7ridci4jzkrpcccm24mz@aphgjsdytirz> (raw)
In-Reply-To: <7BC64F03-A4DF-411F-9B6F-6BCA436D9B50@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 2557 bytes --]
On Mon, Jan 15, 2024 at 09:55:00AM +0100, H. Nikolaus Schaller wrote:
> Hi,
>
> > Am 15.01.2024 um 09:25 schrieb Maxime Ripard <mripard@kernel.org>:
> >
> > Hi,
> >
> > On Fri, Jan 12, 2024 at 06:33:58PM +0100, H. Nikolaus Schaller wrote:
> >>> Am 08.01.2024 um 19:32 schrieb Andrew Davis <afd@ti.com>:
> >>>
> >>> Add SGX GPU device entry to base OMAP4 dtsi file.
> >>>
> >>> Signed-off-by: Andrew Davis <afd@ti.com>
> >>> ---
> >>> arch/arm/boot/dts/ti/omap/omap4.dtsi | 9 +++++----
> >>> 1 file changed, 5 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/arch/arm/boot/dts/ti/omap/omap4.dtsi b/arch/arm/boot/dts/ti/omap/omap4.dtsi
> >>> index 2bbff9032be3e..559b2bfe4ca7c 100644
> >>> --- a/arch/arm/boot/dts/ti/omap/omap4.dtsi
> >>> +++ b/arch/arm/boot/dts/ti/omap/omap4.dtsi
> >>> @@ -501,10 +501,11 @@ sgx_module: target-module@56000000 {
> >>> #size-cells = <1>;
> >>> ranges = <0 0x56000000 0x2000000>;
> >>>
> >>> - /*
> >>> - * Closed source PowerVR driver, no child device
> >>> - * binding or driver in mainline
> >>> - */
> >>> + gpu@0 {
> >>
> >> I wonder why we don't add a "gpu:" label here.
> >>
> >> Almost all other subsystem nodes have one (e.g. emif:, aes:, dss:, dsi:, hdmi:, etc.),
> >> obviously for convenience when using a .dtsi file.
> >>
> >> It would allow a board-specific DTS to easily add status = "disabled" to avoid driver
> >> probing or disabling the GPU (e.g. if there is no display).
> >
> > There's no reason to disable it in the DT: the hardware block would
> > still be there and it's rendering to memory so it still could be useful.
>
> Well, if you know that the board does not have a dm3730 but a dm3725 without
> GPU it is better to disable the GPU completely instead of loading the driver
> and make it detect by some internal bits that it has no GPU on the SoC.
It shouldn't even be in the DTSI if it's not in the SoC.
> > If there's no display on the board and you really don't want the GPU
> > driver, then you can disable the driver or block the module loading, but
> > it should be a distro / package / user decision, not a DT / kernel one
> > still.
>
> The same holds for aes: dss: dsi: hdmi: etc. If they are not used by some
> board file, they don't change a single bit of the DTB [1] which IMHO would
> be of reasonable concern to question additional labels.
Not really, no. If there's no HDMI connector, the HDMI controller is
useless. A GPU without a display can still be useful, depending on the
workload.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-01-15 14:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 18:32 [PATCH RFC v2 00/11] Device tree support for Imagination Series5 GPU Andrew Davis
2024-01-08 18:32 ` [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Andrew Davis
2024-01-09 8:14 ` [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img, powervr to img, powervr-rogue Javier Martinez Canillas
2024-01-09 9:40 ` [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Frank Binns
2024-01-09 11:28 ` Krzysztof Kozlowski
2024-01-09 16:14 ` Andrew Davis
2024-01-09 18:55 ` Krzysztof Kozlowski
2024-01-08 18:32 ` [PATCH RFC v2 02/11] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs Andrew Davis
2024-01-09 11:32 ` Krzysztof Kozlowski
2024-01-09 16:53 ` Andrew Davis
2024-01-09 18:58 ` Krzysztof Kozlowski
2024-01-08 18:32 ` [PATCH RFC v2 03/11] ARM: dts: omap3: Add device tree entry for SGX GPU Andrew Davis
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-08 18:32 ` [PATCH RFC v2 04/11] ARM: dts: omap4: " Andrew Davis
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-12 17:33 ` H. Nikolaus Schaller
2024-01-15 8:25 ` Maxime Ripard
2024-01-15 8:55 ` H. Nikolaus Schaller
2024-01-15 9:50 ` Andreas Kemnade
2024-01-15 14:45 ` Maxime Ripard [this message]
2024-01-08 18:32 ` [PATCH RFC v2 05/11] ARM: dts: omap5: " Andrew Davis
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-08 18:32 ` [PATCH RFC v2 06/11] ARM: dts: AM33xx: " Andrew Davis
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-08 18:32 ` [PATCH RFC v2 07/11] ARM: dts: AM437x: " Andrew Davis
2024-01-09 8:18 ` Javier Martinez Canillas
2024-01-08 18:32 ` [PATCH RFC v2 08/11] ARM: dts: DRA7xx: " Andrew Davis
2024-01-09 8:18 ` Javier Martinez Canillas
2024-01-08 18:33 ` [PATCH RFC v2 09/11] arm64: dts: ti: k3-am654-main: " Andrew Davis
2024-01-08 18:33 ` [PATCH RFC v2 10/11] ARM: dts: sun6i: " Andrew Davis
2024-01-08 18:33 ` [PATCH RFC v2 11/11] MIPS: DTS: jz4780: " Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xagwa5cie5gjzidg5wa6ou3yd2qwta7ridci4jzkrpcccm24mz@aphgjsdytirz \
--to=mripard@kernel.org \
--cc=afd@ti.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=donald.robson@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.binns@imgtec.com \
--cc=hns@goldelico.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matt.coster@imgtec.com \
--cc=nm@ti.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=tony@atomide.com \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).