From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Benjamin Poirier <benjamin.poirier@gmail.com>
Cc: Kira <nyakov13@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, Coiby Xu <coiby.xu@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>, Sven Joachim <svenjoac@gmx.de>,
Ian Kent <raven@themaw.net>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: Revert "staging: qlge: Retire the driver"
Date: Mon, 30 Oct 2023 16:25:40 +0100 [thread overview]
Message-ID: <2023103001-drew-parmesan-c61a@gregkh> (raw)
In-Reply-To: <20231030150400.74178-1-benjamin.poirier@gmail.com>
On Tue, Oct 31, 2023 at 02:04:00AM +1100, Benjamin Poirier wrote:
> This reverts commit 875be090928d19ff4ae7cbaadb54707abb3befdf.
>
> On All Hallows' Eve, fear and cower for it is the return of the undead
> driver.
>
> There was a report [1] from a user of a QLE8142 device. They would like for
> the driver to remain in the kernel. Therefore, revert the removal of the
> qlge driver.
>
> [1] https://lore.kernel.org/netdev/566c0155-4f80-43ec-be2c-2d1ad631bf25@gmail.com/
Who's going to maintain this?
> Reported by: Kira <nyakov13@gmail.com>
> Signed-off-by: Benjamin Poirier <benjamin.poirier@gmail.com>
> ---
>
> Notes:
> Once the removal and revert show up in the net-next tree, I plan to send a
> followup patch to move the driver to drivers/net/ as discussed earlier:
> https://lore.kernel.org/netdev/20231019074237.7ef255d7@kernel.org/
are you going to be willing to maintain this and keep it alive?
I'm all this, if you want to, but I would like it out of staging. So
how about applying this, and a follow-on one that moves it there once
-rc1 is out? And it probably should be in the 'net' tree, as you don't
want 6.7 to come out without the driver at all, right?
> +QLOGIC QLGE 10Gb ETHERNET DRIVER
> +M: Manish Chopra <manishc@marvell.com>
> +M: GR-Linux-NIC-Dev@marvell.com
> +M: Coiby Xu <coiby.xu@gmail.com>
> +L: netdev@vger.kernel.org
> +S: Supported
> +F: Documentation/networking/device_drivers/qlogic/qlge.rst
> +F: drivers/staging/qlge/
It's obvious taht these people are not maintaining this code, so they
should be dropped from the MAINTAINERS file as well.
thanks,
greg k-h
next parent reply other threads:[~2023-10-30 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231030150400.74178-1-benjamin.poirier@gmail.com>
2023-10-30 15:25 ` Greg Kroah-Hartman [this message]
2023-10-30 16:33 ` [PATCH] staging: Revert "staging: qlge: Retire the driver" Benjamin Poirier
2023-10-30 18:42 ` Benjamin Poirier
2023-10-30 21:04 ` Jakub Kicinski
2023-10-31 7:00 ` Greg Kroah-Hartman
2023-11-06 6:54 ` Greg Kroah-Hartman
2023-11-07 2:15 ` Benjamin Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023103001-drew-parmesan-c61a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=benjamin.poirier@gmail.com \
--cc=coiby.xu@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=nyakov13@gmail.com \
--cc=pabeni@redhat.com \
--cc=raven@themaw.net \
--cc=svenjoac@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).