From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, James.Bottomley@HansenPartnership.com, arnd@arndb.de
Cc: linux-parisc@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 4/4] video/sticore: Remove info field from STI struct
Date: Tue, 2 Jan 2024 10:52:36 +0100 [thread overview]
Message-ID: <20240102095604.7276-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20240102095604.7276-1-tzimmermann@suse.de>
The info field in struct sti_struct was used to detect the default
display device. That test is now done with the respective Linux device
and the info field is unused. Remove it.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Tested-by: Helge Deller <deller@gmx.de>
Reviewed-by: Helge Deller <deller@gmx.de>
---
drivers/video/fbdev/stifb.c | 3 ---
include/video/sticore.h | 4 ----
2 files changed, 7 deletions(-)
diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
index 9954640faae6..8e5bac27542d 100644
--- a/drivers/video/fbdev/stifb.c
+++ b/drivers/video/fbdev/stifb.c
@@ -1389,7 +1389,6 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
}
/* save for primary gfx device detection & unregister_framebuffer() */
- sti->info = info;
if (register_framebuffer(fb->info) < 0)
goto out_err4;
@@ -1417,7 +1416,6 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
iounmap(info->screen_base);
out_err0:
framebuffer_release(info);
- sti->info = NULL;
return -ENXIO;
}
@@ -1496,7 +1494,6 @@ stifb_cleanup(void)
framebuffer_release(info);
dev_set_drvdata(sti->dev, NULL);
}
- sti->info = NULL;
}
}
diff --git a/include/video/sticore.h b/include/video/sticore.h
index 9d993e22805d..823666af1871 100644
--- a/include/video/sticore.h
+++ b/include/video/sticore.h
@@ -3,7 +3,6 @@
#define STICORE_H
struct device;
-struct fb_info;
/* generic STI structures & functions */
@@ -368,9 +367,6 @@ struct sti_struct {
/* PCI data structures (pg. 17ff from sti.pdf) */
u8 rm_entry[16]; /* pci region mapper array == pci config space offset */
- /* pointer to the fb_info where this STI device is used */
- struct fb_info *info;
-
/* pointer to the parent device */
struct device *dev;
--
2.43.0
prev parent reply other threads:[~2024-01-02 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 9:52 [PATCH v2 0/4] arch/parisc: Detect primary framebuffer from device Thomas Zimmermann
2024-01-02 9:52 ` [PATCH v2 1/4] video/sticore: Store ROM device in STI struct Thomas Zimmermann
2024-01-02 9:52 ` [PATCH v2 2/4] fbdev/stifb: Allocate fb_info instance with framebuffer_alloc() Thomas Zimmermann
2024-01-02 9:52 ` [PATCH v2 3/4] arch/parisc: Detect primary video device from device instance Thomas Zimmermann
2024-01-02 9:52 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240102095604.7276-5-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arnd@arndb.de \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).