From: Helge Deller <deller@gmx.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: linux-parisc@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] parisc: led: Convert to platform remove callback returning void
Date: Fri, 8 Mar 2024 10:00:34 +0100 [thread overview]
Message-ID: <5096df26-83fe-4843-afd0-54de8cbb7d6c@gmx.de> (raw)
In-Reply-To: <a6c58690efa78eb20258f5831f0ed1861e357844.1709886922.git.u.kleine-koenig@pengutronix.de>
On 3/8/24 09:51, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
applied to parisc tree.
Thanks!
Helge
> ---
> drivers/parisc/led.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
> index 1f75d2416001..b49cb010a4d8 100644
> --- a/drivers/parisc/led.c
> +++ b/drivers/parisc/led.c
> @@ -308,15 +308,13 @@ static int hppa_led_generic_probe(struct platform_device *pdev,
> return 0;
> }
>
> -static int platform_led_remove(struct platform_device *pdev)
> +static void platform_led_remove(struct platform_device *pdev)
> {
> struct hppa_drvdata *p = platform_get_drvdata(pdev);
> int i;
>
> for (i = 0; i < NUM_LEDS_PER_BOARD; i++)
> led_classdev_unregister(&p->leds[i].led_cdev);
> -
> - return 0;
> }
>
> static struct led_type mainboard_led_types[NUM_LEDS_PER_BOARD] = {
> @@ -371,7 +369,7 @@ MODULE_ALIAS("platform:platform-leds");
>
> static struct platform_driver hppa_mainboard_led_driver = {
> .probe = platform_led_probe,
> - .remove = platform_led_remove,
> + .remove_new = platform_led_remove,
> .driver = {
> .name = "platform-leds",
> },
>
> base-commit: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd
prev parent reply other threads:[~2024-03-08 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 8:51 [PATCH] parisc: led: Convert to platform remove callback returning void Uwe Kleine-König
2024-03-08 9:00 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5096df26-83fe-4843-afd0-54de8cbb7d6c@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=kernel@pengutronix.de \
--cc=linux-parisc@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).