From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
deller@gmx.de, sam@ravnborg.org, arnd@arndb.de, daniel@ffwll.ch
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-nvidia@lists.surfsouth.com, linux-omap@vger.kernel.org,
linux-parisc@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH 00/46] fbdev: Init fb_ops with helpers for I/O memory
Date: Wed, 18 Oct 2023 10:25:43 +0200 [thread overview]
Message-ID: <877cnkqquw.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <20230927074722.6197-1-tzimmermann@suse.de>
Thomas Zimmermann <tzimmermann@suse.de> writes:
> Initialize struct fb_ops for drivers for hardware with framebuffers
> in I/O-memory ranges with the respective helper macros. Also select
> the appropriate Kconfig dependencies.
>
> The patchset is part of a larger effort to modularize the fbdev core
> and make it more adaptable. Most of these drivers do not initialize
> the fb_read, fb_write and fb_mmap callbacks in fb_ops. By leaving the
> callback pointers to NULL, they rely on the fbdev core to invoke the
> I/O-memory helpers by default. This default makes it impossible to
> remove the I/O-memory helpers on systems that don't need them. Setting
> the pointers explicitly will allow for the removal of the default. If
> a callback in fb_ops is unset, the operation will then be unsupported.
>
> Initializing struct fb_ops via helpers macros will also allow for a
> fine-grained setup, depending on Kconfig options. For example, it
> will be possible to leave out file I/O if FB_DEVICE has not been
> set.
>
> This patchset contains the majority of fbdev driver work. The updated
> drivers now initialize fb_ops with __FB_DEFAULT_IOMEM_OPS_RDWR,
> __FB_DEFAULT_IOMEM_OPS_DRAW and/or __FB_DEFAULT_IOMEM_OPS_MMAP if
> possible. Some drivers now use FB_DEFAULT_IOMEM_OPS, which sets all
> fields correctly. In Kconfig, each driver selects FB_IOMEM_FOPS to
> get the helpers for I/O memory. Drivers that use _RDWR, _DRAW and
> _MMAP unconditionally select FB_IOMEM_HELPERS, which selects the
> correct modules automatically.
>
I looked to all the driver changes as well and couldn't spot any issues.
For all the driver patches:
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
prev parent reply other threads:[~2023-10-18 8:26 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 7:26 [PATCH 00/46] fbdev: Init fb_ops with helpers for I/O memory Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 01/46] fbdev: Provide I/O-memory helpers as module Thomas Zimmermann
2023-10-18 8:16 ` Javier Martinez Canillas
2023-09-27 7:26 ` [PATCH 02/46] fbdev/68328fb: Initialize fb_ops to fbdev I/O-memory helpers Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 03/46] fbdev/amba-clcd: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 04/46] fbdev/amifb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 05/46] fbdev/arkfb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 06/46] fbdev/atafb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 07/46] fbdev/atyfb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 08/46] fbdev/au1100fb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 09/46] fbdev/cirrusfb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 10/46] fbdev/cobalt-lcd: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 11/46] fbdev/controlfb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 12/46] fbdev/cyber2000fb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 13/46] fbdev/dnfb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 14/46] fbdev/ep93xx-fb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 15/46] fbdev/gbefb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 16/46] fbdev/hgafb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 17/46] fbdev/hitfb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 18/46] fbdev/hpfb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 19/46] fbdev/i810fb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 20/46] fbdev/imsttfb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 21/46] fbdev/intelfb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 22/46] fbdev/matroxfb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 23/46] fbdev/neofb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 24/46] fbdev/nvidiafb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 25/46] fbdev/omapfb: " Thomas Zimmermann
2023-09-27 7:26 ` [PATCH 26/46] fbdev/pm2fb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 27/46] fbdev/pm3fb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 28/46] fbdev/pvr2fb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 29/46] fbdev/radeon: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 30/46] fbdev/rivafb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 31/46] fbdev/s1d13xxxfb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 32/46] fbdev/s3fb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 33/46] fbdev/sa1100fb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 34/46] fbdev/savagefb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 35/46] fbdev/sisfb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 36/46] fbdev/sm501fb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 37/46] fbdev/sm712fb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 38/46] fbdev/stifb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 39/46] fbdev/sunxvr500: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 40/46] fbdev/tdfxfb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 41/46] fbdev/tgafb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 42/46] fbdev/tridentfb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 43/46] fbdev/vermilionfb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 44/46] fbdev/vga16fb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 45/46] fbdev/viafb: " Thomas Zimmermann
2023-09-27 7:27 ` [PATCH 46/46] fbdev/vt8623fb: " Thomas Zimmermann
2023-10-18 8:25 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cnkqquw.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-nvidia@lists.surfsouth.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).