From: Aksh Garg <a-garg7@ti.com>
To: Hans Zhang <18255117159@163.com>,
Manikandan Karunakaran Pillai <mpillai@cadence.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"kwilczynski@kernel.org" <kwilczynski@kernel.org>,
"mani@kernel.org" <mani@kernel.org>
Cc: "robh@kernel.org" <robh@kernel.org>,
"s-vadapalli@ti.com" <s-vadapalli@ti.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 3/3] PCI: cadence: Add LGA IP debugfs for LTSSM status
Date: Wed, 20 May 2026 10:57:07 +0530 [thread overview]
Message-ID: <026b1332-1d53-44bb-8528-2b6be5f91233@ti.com> (raw)
In-Reply-To: <4768d23f-b07c-4cb5-b626-cf4aaeca2647@163.com>
On 20/05/26 10:10, Hans Zhang wrote:
>
>
> On 5/20/26 12:36, Aksh Garg wrote:
>>
>>
>> On 20/05/26 08:29, Hans Zhang wrote:
>>>
>>>
>>> On 5/20/26 10:34, Manikandan Karunakaran Pillai wrote:
>>>>> EXTERNAL MAIL
>>>>>
>>>>>
>>>>> Extend debugfs support to LGA-based Cadence PCIe controllers. The
>>>>> 'ltssm_status' file now works for both HPA and LGA IP by selecting the
>>>>> appropriate register access based on the 'is_hpa' flag.
>>>>>
>>>>> Signed-off-by: Hans Zhang <18255117159@163.com>
>>>>> ---
>>>>> .../controller/cadence/pcie-cadence-debugfs.c | 61 ++++++++++++++++++-
>>>>> .../pci/controller/cadence/pcie-cadence-ep.c | 3 +
>>>>> .../controller/cadence/pcie-cadence-host.c | 9 ++-
>>>>> drivers/pci/controller/cadence/pcie-cadence.h | 43 +++++++++++++
>>>>> 4 files changed, 112 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/drivers/pci/controller/cadence/pcie-cadence-debugfs.c
>>>>> b/drivers/pci/controller/cadence/pcie-cadence-debugfs.c
>>>>> index 97c5deef2b1a..0a308f95e9f6 100644
>>>>> --- a/drivers/pci/controller/cadence/pcie-cadence-debugfs.c
>>>>> +++ b/drivers/pci/controller/cadence/pcie-cadence-debugfs.c
>>>>> @@ -13,6 +13,58 @@
>>>>>
>>>>> #define CDNS_DEBUGFS_BUF_MAX 128
>>>>
>>>> Where is CDNS_DEBUGFS_BUF_MAX used for ?
>>>
>>> Hi Manikandan,
>>>
>>> Thank you very much for your reply and reminder.
>>>
>>> This macro definition was used in patch 0002. Since I compiled the
>>> code after applying all three patches together, I didn't notice this
>>> issue. The next version will be fixed and will be included in patch
>>> 0002.
>>
>> I didn't understood the issue here. The macro definition was indeed
>> introduced in patch 0002 itself right? Am I missing something here?
>
> Hi Aksh,
>
> If only patches 0001 and 0002 are applied, there will be a compilation
> error. Patch 0002 will fail to find CDNS_DEBUGFS_BUF_MAX. Previously, I
> split LGA into patch 0003. I didn't notice this issue. Do you think I
> have explained it clearly?
I see no compilation errors after applying only patch 1 and 2.
CDNS_DEBUGFS_BUF_MAX macro is defined in the patch 2 itself.
Patch 3 just uses the CDNS_DEBUGFS_BUF_MAX macro definition code for the
reference point to add the new code lines in that patch, it didn't
introduced the macro here.
>
> Best regards,
> Hans
>
next prev parent reply other threads:[~2026-05-20 5:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 12:36 [PATCH v6 0/3] PCI: cadence: Add LTSSM debugfs Hans Zhang
2026-05-19 12:36 ` [PATCH v6 1/3] PCI: cadence: Add HPA architecture flag Hans Zhang
2026-05-19 12:36 ` [PATCH v6 2/3] PCI: cadence: Add HPA IP debugfs for LTSSM status Hans Zhang
2026-05-19 13:20 ` sashiko-bot
2026-05-20 7:26 ` Aksh Garg
2026-05-20 14:54 ` Hans Zhang
2026-05-19 12:36 ` [PATCH v6 3/3] PCI: cadence: Add LGA " Hans Zhang
2026-05-20 2:34 ` Manikandan Karunakaran Pillai
2026-05-20 2:59 ` Hans Zhang
2026-05-20 4:36 ` Aksh Garg
2026-05-20 4:40 ` Hans Zhang
2026-05-20 5:27 ` Aksh Garg [this message]
2026-05-20 5:44 ` Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=026b1332-1d53-44bb-8528-2b6be5f91233@ti.com \
--to=a-garg7@ti.com \
--cc=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mpillai@cadence.com \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).