From: Bjorn Helgaas <helgaas@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
imx@lists.linux.dev, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 5/5] PCI: dwc: Add generic MSG TLP support for sending PME_Turn_Off when system suspend
Date: Wed, 17 Apr 2024 10:10:04 -0500 [thread overview]
Message-ID: <20240417151004.GA202039@bhelgaas> (raw)
In-Reply-To: <Zh/ezLdct9sisvhc@lizhi-Precision-Tower-5810>
On Wed, Apr 17, 2024 at 10:38:04AM -0400, Frank Li wrote:
> On Wed, Apr 17, 2024 at 03:49:44PM +0530, Manivannan Sadhasivam wrote:
> > On Mon, Apr 15, 2024 at 03:33:29PM -0400, Frank Li wrote:
> > > + /*
> > > + * Allocate the resource for MSG TLP before programming the iATU outbound window in
> > > + * dw_pcie_setup_rc(). Since the allocation depends on the value of 'region_align', this has
> > > + * to be done after dw_pcie_iatu_detect().
> >
> > Please wrap the comments to 80 columns.
>
> New code style is 100 columns. does comments still stick to 80 columns?
I care more about files being consistent internally than I do about
adhering to a new 100 column rule.
With very few exceptions, pcie-designware-host.c fits in 80 columns.
I think there's no point in adding a comment using 100 columns. That
leadds to either a window sized to accommodate 100 columns, where 20
columns are wasted for all the existing code and comments, or a window
sized for 80 columns, where the new comment looks ugly. Neither is
attractive.
Bjorn
prev parent reply other threads:[~2024-04-17 15:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 19:33 [PATCH v6 0/5] PCI: dwc: Add common pme_turn_off message by using outbound iATU Frank Li
2024-04-15 19:33 ` [PATCH v6 1/5] PCI: Add INTx Mechanism Messages macros Frank Li
2024-04-15 19:33 ` [PATCH v6 2/5] PCI: dwc: Consolidate args of dw_pcie_prog_outbound_atu() into a structure Frank Li
2024-04-15 19:33 ` [PATCH v6 3/5] PCI: dwc: Add outbound MSG TLPs support Frank Li
2024-04-15 19:33 ` [PATCH v6 4/5] PCI: Add PCIE_MSG_CODE_PME_TURN_OFF message macro Frank Li
2024-04-16 17:02 ` Bjorn Helgaas
2024-04-17 7:56 ` Manivannan Sadhasivam
2024-04-17 11:14 ` Bjorn Helgaas
2024-04-15 19:33 ` [PATCH v6 5/5] PCI: dwc: Add generic MSG TLP support for sending PME_Turn_Off when system suspend Frank Li
2024-04-17 10:19 ` Manivannan Sadhasivam
2024-04-17 14:38 ` Frank Li
2024-04-17 14:52 ` Manivannan Sadhasivam
2024-04-17 15:10 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417151004.GA202039@bhelgaas \
--to=helgaas@kernel.org \
--cc=Frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=imx@lists.linux.dev \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).