From: Bjorn Helgaas <helgaas@kernel.org>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andres Salomon <dilinger@queued.net>
Subject: Re: [PATCH] x86: Code cleanup for ehci_hdr
Date: Fri, 3 May 2024 17:12:54 -0500 [thread overview]
Message-ID: <20240503221254.GA1607085@bhelgaas> (raw)
In-Reply-To: <20240125030623.513902-1-chentao@kylinos.cn>
[+cc Andres, author of 3ef0e1f8cad0]
On Thu, Jan 25, 2024 at 11:06:23AM +0800, Kunwu Chan wrote:
> This part was commented from commit 3ef0e1f8cad0
> ("x86: olpc: add One Laptop Per Child architecture support")
> in about 16 years before.
>
> If there are no plans to enable this part code in the future,
> we can remove this dead code.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Applied to pci/misc for v6.10, thanks.
> ---
> arch/x86/pci/olpc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/pci/olpc.c b/arch/x86/pci/olpc.c
> index f3aab76e357a..4b18c6404363 100644
> --- a/arch/x86/pci/olpc.c
> +++ b/arch/x86/pci/olpc.c
> @@ -154,9 +154,6 @@ static const uint32_t ehci_hdr[] = { /* dev f function 4 - devfn = 7d */
> 0x0, 0x40, 0x0, 0x40a, /* CapPtr INT-D, IRQA */
> 0xc8020001, 0x0, 0x0, 0x0, /* Capabilities - 40 is R/O, 44 is
> mask 8103 (power control) */
> -#if 0
> - 0x1, 0x40080000, 0x0, 0x0, /* EECP - see EHCI spec section 2.1.7 */
> -#endif
> 0x01000001, 0x0, 0x0, 0x0, /* EECP - see EHCI spec section 2.1.7 */
> 0x2020, 0x0, 0x0, 0x0, /* (EHCI page 8) 60 SBRN (R/O),
> 61 FLADJ (R/W), PORTWAKECAP */
> --
> 2.39.2
>
prev parent reply other threads:[~2024-05-03 22:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 3:06 [PATCH] x86: Code cleanup for ehci_hdr Kunwu Chan
2024-05-03 22:12 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240503221254.GA1607085@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=chentao@kylinos.cn \
--cc=dave.hansen@linux.intel.com \
--cc=dilinger@queued.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).