From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Guangbo Cui <jckeep.cuiguangbo@gmail.com>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Waiman Long <longman@redhat.com>,
linux-rt-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 2/2] PCI/aer_inject: Convert inject_lock to raw_spinlock_t
Date: Mon, 3 Nov 2025 21:02:53 +0100 [thread overview]
Message-ID: <20251103200253.SlYC8MU7@linutronix.de> (raw)
In-Reply-To: <20251103192120.GJ3419281@noisy.programming.kicks-ass.net>
On 2025-11-03 20:21:20 [+0100], Peter Zijlstra wrote:
> On Sun, Nov 02, 2025 at 10:57:06AM +0000, Guangbo Cui wrote:
> > The AER injection path may run in interrupt-disabled context while
> > holding inject_lock. On PREEMPT_RT kernels, spinlock_t becomes a
> > sleeping lock, so it must not be taken while a raw_spinlock_t is held.
> > Doing so violates lock ordering rules and trigger lockdep reports
> > such as “Invalid wait context”.
> >
> > Convert inject_lock to raw_spinlock_t to ensure non-sleeping locking
> > semantics. The protected list is bounded and used only for debugging,
> > so raw locking will not cause latency issues.
>
> Bounded how?
I think I used the term "not bounded" and said "it does not matter
because it is debugging only". Best would be to leave that part and use
only "only for debugging".
> Also,
Sebastian
next prev parent reply other threads:[~2025-11-03 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 10:57 [PATCH v4 0/2] PCI/aer_inject: Adjust locking for PREEMPT_RT Guangbo Cui
2025-11-02 10:57 ` [PATCH v4 1/2] PCI/aer_inject: Remove unnecessary lock in aer_inject_exit Guangbo Cui
2025-11-02 10:57 ` [PATCH v4 2/2] PCI/aer_inject: Convert inject_lock to raw_spinlock_t Guangbo Cui
2025-11-03 19:21 ` Peter Zijlstra
2025-11-03 19:27 ` Peter Zijlstra
2025-11-06 13:08 ` Guangbo Cui
2025-11-06 14:05 ` Peter Zijlstra
2025-11-11 14:39 ` Sebastian Andrzej Siewior
2025-11-03 20:02 ` Sebastian Andrzej Siewior [this message]
2025-11-03 20:29 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103200253.SlYC8MU7@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bhelgaas@google.com \
--cc=boqun.feng@gmail.com \
--cc=clrkwllms@kernel.org \
--cc=jckeep.cuiguangbo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).