From: Manivannan Sadhasivam <mani@kernel.org>
To: Thierry Reding <thierry.reding@kernel.org>
Cc: "Damien Le Moal" <dlemoal@kernel.org>,
"Niklas Cassel" <cassel@kernel.org>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Lyude Paul" <lyude@redhat.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Mikko Perttunen" <mperttunen@nvidia.com>,
"Dmitry Osipenko" <digetx@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Mathias Nyman" <mathias.nyman@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
linux-ide@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org, linux-media@vger.kernel.org,
linux-pci@vger.kernel.org, linux-usb@vger.kernel.org,
"Thierry Reding" <treding@nvidia.com>
Subject: Re: [PATCH 5/9] PCI: tegra: Explicitly specify PMC instance to use
Date: Fri, 15 May 2026 22:27:48 +0530 [thread overview]
Message-ID: <5gtqxwkjw6adv65tz7ji5wxdyscqe5zlk2ugkogrsrnwituhhm@f3iaamhyxdcm> (raw)
In-Reply-To: <rt3tpcu7eucylbxurtvraghnyljkv52zau75jwkkbtyfslc2ox@2bjkryjd4nqp>
On Fri, May 15, 2026 at 10:26:12PM +0530, Manivannan Sadhasivam wrote:
> On Wed, May 06, 2026 at 03:41:56PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Currently the kernel relies on a global variable to reference the PMC
> > context. Use an explicit lookup for the PMC and pass that to the public
> > PMC APIs.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > drivers/pci/controller/pci-tegra.c | 20 +++++++++++++++-----
> > 1 file changed, 15 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> > index 512309763d1f..2c6c521e6901 100644
> > --- a/drivers/pci/controller/pci-tegra.c
> > +++ b/drivers/pci/controller/pci-tegra.c
> > @@ -340,6 +340,8 @@ struct tegra_pcie {
> > struct reset_control *afi_rst;
> > struct reset_control *pcie_xrst;
> >
> > + struct tegra_pmc *pmc;
> > +
> > bool legacy_phy;
> > struct phy *phy;
> >
> > @@ -1165,7 +1167,7 @@ static void tegra_pcie_power_off(struct tegra_pcie *pcie)
> > clk_disable_unprepare(pcie->afi_clk);
> >
> > if (!dev->pm_domain)
> > - tegra_powergate_power_off(TEGRA_POWERGATE_PCIE);
> > + tegra_pmc_powergate_power_off(pcie->pmc, TEGRA_POWERGATE_PCIE);
> >
> > err = regulator_bulk_disable(pcie->num_supplies, pcie->supplies);
> > if (err < 0)
> > @@ -1183,7 +1185,7 @@ static int tegra_pcie_power_on(struct tegra_pcie *pcie)
> > reset_control_assert(pcie->pex_rst);
> >
> > if (!dev->pm_domain)
> > - tegra_powergate_power_off(TEGRA_POWERGATE_PCIE);
> > + tegra_pmc_powergate_power_off(pcie->pmc, TEGRA_POWERGATE_PCIE);
> >
> > /* enable regulators */
> > err = regulator_bulk_enable(pcie->num_supplies, pcie->supplies);
> > @@ -1191,12 +1193,14 @@ static int tegra_pcie_power_on(struct tegra_pcie *pcie)
> > dev_err(dev, "failed to enable regulators: %d\n", err);
> >
> > if (!dev->pm_domain) {
> > - err = tegra_powergate_power_on(TEGRA_POWERGATE_PCIE);
> > + err = tegra_pmc_powergate_power_on(pcie->pmc,
> > + TEGRA_POWERGATE_PCIE);
> > if (err) {
> > dev_err(dev, "failed to power ungate: %d\n", err);
> > goto regulator_disable;
> > }
> > - err = tegra_powergate_remove_clamping(TEGRA_POWERGATE_PCIE);
> > + err = tegra_pmc_powergate_remove_clamping(pcie->pmc,
> > + TEGRA_POWERGATE_PCIE);
> > if (err) {
> > dev_err(dev, "failed to remove clamp: %d\n", err);
> > goto powergate;
> > @@ -1234,7 +1238,7 @@ static int tegra_pcie_power_on(struct tegra_pcie *pcie)
> > clk_disable_unprepare(pcie->afi_clk);
> > powergate:
> > if (!dev->pm_domain)
> > - tegra_powergate_power_off(TEGRA_POWERGATE_PCIE);
> > + tegra_pmc_powergate_power_off(pcie->pmc, TEGRA_POWERGATE_PCIE);
> > regulator_disable:
> > regulator_bulk_disable(pcie->num_supplies, pcie->supplies);
> >
> > @@ -1432,6 +1436,12 @@ static int tegra_pcie_get_resources(struct tegra_pcie *pcie)
> > return err;
> > }
> >
> > + pcie->pmc = devm_tegra_pmc_get(dev);
> > + if (IS_ERR(pcie->pmc)) {
> > + dev_err_probe(dev, PTR_ERR(pcie->pmc), "failed to get PMC\n");
> > + return err;
>
> As Sashiko pointed out, you need to return dev_err_probe() directly.
>
With the change,
Acked-by: Manivannan Sadhasivam <mani@kernel.org>
Feel free to take it through Tegra tree.
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2026-05-15 16:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 13:41 [PATCH 0/9] soc/tegra: pmc: Clean up legacy code Thierry Reding
2026-05-06 13:41 ` [PATCH 1/9] ata: ahci_tegra: Explicitly specify PMC instance to use Thierry Reding
2026-05-06 13:54 ` Damien Le Moal
2026-05-06 13:41 ` [PATCH 2/9] drm/nouveau: tegra: " Thierry Reding
2026-05-21 8:00 ` Thierry Reding
2026-05-21 14:04 ` Danilo Krummrich
2026-05-22 10:15 ` Thierry Reding
2026-05-06 13:41 ` [PATCH 3/9] drm/tegra: " Thierry Reding
2026-05-06 20:41 ` sashiko-bot
2026-05-06 13:41 ` [PATCH 4/9] media: vde: " Thierry Reding
2026-05-21 7:57 ` Thierry Reding
2026-05-06 13:41 ` [PATCH 5/9] PCI: tegra: " Thierry Reding
2026-05-06 20:55 ` sashiko-bot
2026-05-15 16:55 ` Manivannan Sadhasivam
2026-05-15 16:57 ` Manivannan Sadhasivam [this message]
2026-05-06 13:41 ` [PATCH 6/9] usb: xhci: " Thierry Reding
2026-05-21 7:59 ` Thierry Reding
2026-05-21 14:00 ` Mathias Nyman
2026-05-06 13:41 ` [PATCH 7/9] soc/tegra: pmc: Create PMC context dynamically Thierry Reding
2026-05-06 21:40 ` sashiko-bot
2026-05-06 13:41 ` [PATCH 8/9] soc/tegra: pmc: Remove unused legacy functions Thierry Reding
2026-05-06 13:42 ` [PATCH 9/9] soc/tegra: pmc: Move legacy code behind CONFIG_ARM guard Thierry Reding
2026-05-06 22:37 ` sashiko-bot
2026-05-26 10:17 ` [PATCH 0/9] soc/tegra: pmc: Clean up legacy code Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5gtqxwkjw6adv65tz7ji5wxdyscqe5zlk2ugkogrsrnwituhhm@f3iaamhyxdcm \
--to=mani@kernel.org \
--cc=airlied@gmail.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dakr@kernel.org \
--cc=digetx@gmail.com \
--cc=dlemoal@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mathias.nyman@intel.com \
--cc=mchehab@kernel.org \
--cc=mperttunen@nvidia.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=thierry.reding@kernel.org \
--cc=treding@nvidia.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).