From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: bhelgaas@google.com, dave.hansen@linux.intel.com, x86@kernel.org,
linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86: ce4100: Remove unused struct 'sim_reg_op'
Date: Wed, 8 May 2024 10:55:07 +0300 (EEST) [thread overview]
Message-ID: <8a3efad2-8e65-5ba4-573c-4fb041bf675b@linux.intel.com> (raw)
In-Reply-To: <20240507232348.46677-1-linux@treblig.org>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On Wed, 8 May 2024, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> struct 'sim_reg_op' doesn't look like it was ever used.
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> arch/x86/pci/ce4100.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
> index 87313701f069e..f5dbd25651e0f 100644
> --- a/arch/x86/pci/ce4100.c
> +++ b/arch/x86/pci/ce4100.c
> @@ -35,12 +35,6 @@ struct sim_dev_reg {
> struct sim_reg sim_reg;
> };
>
> -struct sim_reg_op {
> - void (*init)(struct sim_dev_reg *reg);
> - void (*read)(struct sim_dev_reg *reg, u32 value);
> - void (*write)(struct sim_dev_reg *reg, u32 value);
> -};
> -
Thanks.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
prev parent reply other threads:[~2024-05-08 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 23:23 [PATCH v2] x86: ce4100: Remove unused struct 'sim_reg_op' linux
2024-05-08 7:55 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a3efad2-8e65-5ba4-573c-4fb041bf675b@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@treblig.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).