From: Frank Li <Frank.li@nxp.com>
To: Koichiro Den <den@valinux.co.jp>
Cc: ntb@lists.linux.dev, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, jdmason@kudzu.us,
dave.jiang@intel.com, allenbh@gmail.com, mani@kernel.org,
kwilczynski@kernel.org, kishon@kernel.org, bhelgaas@google.com,
jbrunet@baylibre.com, lpieralisi@kernel.org, yebin10@huawei.com,
geert+renesas@glider.be, arnd@arndb.de
Subject: Re: [PATCH v2 4/6] PCI: endpoint: pci-epf-ntb: Remove duplicate resource teardown
Date: Wed, 29 Oct 2025 12:48:55 -0400 [thread overview]
Message-ID: <aQJFd8Btdh1EY0Qz@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20251029080321.807943-5-den@valinux.co.jp>
On Wed, Oct 29, 2025 at 05:03:19PM +0900, Koichiro Den wrote:
> epf_ntb_epc_destroy() duplicates the teardown that the caller is
> supposed to do later. This leads to an oops when .allow_link fails or
> when .drop_link is performed. Remove the helper.
>
> Also drop pci_epc_put(). EPC device refcounting is tied to configfs EPC
> group lifetime, and pci_epc_put() in the .drop_link path is sufficient.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 8b821cf76150 ("PCI: endpoint: Add EP function driver to provide NTB functionality")
> Signed-off-by: Koichiro Den <den@valinux.co.jp>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/pci/endpoint/functions/pci-epf-ntb.c | 56 +-------------------
> 1 file changed, 2 insertions(+), 54 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-ntb.c b/drivers/pci/endpoint/functions/pci-epf-ntb.c
> index e01a98e74d21..7702ebb81d99 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-ntb.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-ntb.c
> @@ -1494,47 +1494,6 @@ static int epf_ntb_db_mw_bar_init(struct epf_ntb *ntb,
> return ret;
> }
>
> -/**
> - * epf_ntb_epc_destroy_interface() - Cleanup NTB EPC interface
> - * @ntb: NTB device that facilitates communication between HOST1 and HOST2
> - * @type: PRIMARY interface or SECONDARY interface
> - *
> - * Unbind NTB function device from EPC and relinquish reference to pci_epc
> - * for each of the interface.
> - */
> -static void epf_ntb_epc_destroy_interface(struct epf_ntb *ntb,
> - enum pci_epc_interface_type type)
> -{
> - struct epf_ntb_epc *ntb_epc;
> - struct pci_epc *epc;
> - struct pci_epf *epf;
> -
> - if (type < 0)
> - return;
> -
> - epf = ntb->epf;
> - ntb_epc = ntb->epc[type];
> - if (!ntb_epc)
> - return;
> - epc = ntb_epc->epc;
> - pci_epc_remove_epf(epc, epf, type);
> - pci_epc_put(epc);
> -}
> -
> -/**
> - * epf_ntb_epc_destroy() - Cleanup NTB EPC interface
> - * @ntb: NTB device that facilitates communication between HOST1 and HOST2
> - *
> - * Wrapper for epf_ntb_epc_destroy_interface() to cleanup all the NTB interfaces
> - */
> -static void epf_ntb_epc_destroy(struct epf_ntb *ntb)
> -{
> - enum pci_epc_interface_type type;
> -
> - for (type = PRIMARY_INTERFACE; type <= SECONDARY_INTERFACE; type++)
> - epf_ntb_epc_destroy_interface(ntb, type);
> -}
> -
> /**
> * epf_ntb_epc_create_interface() - Create and initialize NTB EPC interface
> * @ntb: NTB device that facilitates communication between HOST1 and HOST2
> @@ -1614,15 +1573,8 @@ static int epf_ntb_epc_create(struct epf_ntb *ntb)
>
> ret = epf_ntb_epc_create_interface(ntb, epf->sec_epc,
> SECONDARY_INTERFACE);
> - if (ret) {
> + if (ret)
> dev_err(dev, "SECONDARY intf: Fail to create NTB EPC\n");
> - goto err_epc_create;
> - }
> -
> - return 0;
> -
> -err_epc_create:
> - epf_ntb_epc_destroy_interface(ntb, PRIMARY_INTERFACE);
>
> return ret;
> }
> @@ -1887,7 +1839,7 @@ static int epf_ntb_bind(struct pci_epf *epf)
> ret = epf_ntb_init_epc_bar(ntb);
> if (ret) {
> dev_err(dev, "Failed to create NTB EPC\n");
> - goto err_bar_init;
> + return ret;
> }
>
> ret = epf_ntb_config_spad_bar_alloc_interface(ntb);
> @@ -1909,9 +1861,6 @@ static int epf_ntb_bind(struct pci_epf *epf)
> err_bar_alloc:
> epf_ntb_config_spad_bar_free(ntb);
>
> -err_bar_init:
> - epf_ntb_epc_destroy(ntb);
> -
> return ret;
> }
>
> @@ -1927,7 +1876,6 @@ static void epf_ntb_unbind(struct pci_epf *epf)
>
> epf_ntb_epc_cleanup(ntb);
> epf_ntb_config_spad_bar_free(ntb);
> - epf_ntb_epc_destroy(ntb);
> }
>
> #define EPF_NTB_R(_name) \
> --
> 2.48.1
>
next prev parent reply other threads:[~2025-10-29 16:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 8:03 [PATCH v2 0/6] PCI: endpoint/NTB: Harden vNTB resource management Koichiro Den
2025-10-29 8:03 ` [PATCH v2 1/6] NTB: epf: Avoid pci_iounmap() with offset when PEER_SPAD and CONFIG share BAR Koichiro Den
2025-10-29 8:03 ` [PATCH v2 2/6] PCI: endpoint: Fix parameter order for .drop_link Koichiro Den
2025-10-29 8:03 ` [PATCH v2 3/6] PCI: endpoint: pci-epf-vntb: Remove duplicate resource teardown Koichiro Den
2025-10-29 8:03 ` [PATCH v2 4/6] PCI: endpoint: pci-epf-ntb: " Koichiro Den
2025-10-29 16:48 ` Frank Li [this message]
2025-10-29 8:03 ` [PATCH v2 5/6] NTB: epf: vntb: Stop cmd_handler work in epf_ntb_epc_cleanup Koichiro Den
2025-10-29 8:03 ` [PATCH v2 6/6] PCI: endpoint: pci-epf-vntb: manage ntb_dev lifetime and fix vpci bus teardown Koichiro Den
2025-10-29 16:53 ` Frank Li
2025-10-30 2:20 ` Koichiro Den
2025-10-31 19:52 ` Frank Li
2025-11-04 1:13 ` Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQJFd8Btdh1EY0Qz@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=allenbh@gmail.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=den@valinux.co.jp \
--cc=geert+renesas@glider.be \
--cc=jbrunet@baylibre.com \
--cc=jdmason@kudzu.us \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=ntb@lists.linux.dev \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).