From: Jon Hunter <jonathanh@nvidia.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
"Manikanta Maddireddy" <mmaddireddy@nvidia.com>
Subject: Re: [PATCH] PCI: tegra194: Set address alignment for endpoint mode
Date: Fri, 26 Apr 2024 15:17:50 +0100 [thread overview]
Message-ID: <b0367d26-8524-4fb2-8567-04ad1f290be3@nvidia.com> (raw)
In-Reply-To: <Ziuj-mSFQ8xPutXX@ryzen.lan>
On 26/04/2024 13:54, Niklas Cassel wrote:
> On Fri, Apr 26, 2024 at 01:27:31PM +0100, Jon Hunter wrote:
>> Tegra194 and Tegra234 devices require that the endpoint address is
>> aligned on a 64kB boundary and therefore, set the endpoint address
>> alignment to 64kB in the Tegra194 PCIe driver.
>
> Hello Jon,
>
> While I think the change in this patch looks good,
> I think you need to rephrase your commit message.
>
> The 'align' of pci_epc_features represents inbound ATU constraints.
> (So for BAR access.)
> See Kishon reply at:
> https://lore.kernel.org/linux-pci/dccb87db-d826-43fa-a499-cf36ea9b10d5@amd.com/T/#m7697d1d745d8499fc6b8db855b7f93dafd7ed5b3
Thanks! I will fix up the commit message and re-send.
Jon
prev parent reply other threads:[~2024-04-26 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 12:27 [PATCH] PCI: tegra194: Set address alignment for endpoint mode Jon Hunter
2024-04-26 12:54 ` Niklas Cassel
2024-04-26 14:17 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0367d26-8524-4fb2-8567-04ad1f290be3@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).