From: Manivannan Sadhasivam <mani@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@oss.qualcomm.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Hanjie Lin" <hanjie.lin@amlogic.com>,
"Yue Wang" <yue.wang@amlogic.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Andrew Murray" <amurray@thegoodpenguin.co.uk>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH RESEND 1/3] dt-bindings: PCI: amlogic: Fix the register name of the DBI region
Date: Mon, 3 Nov 2025 15:42:58 +0530 [thread overview]
Message-ID: <rguwscxck7vel3hjdd2hlkypzdbwdvafdryxtz5benweduh4eg@sny4rr2nx5aq> (raw)
In-Reply-To: <31271df3-73e1-4eea-9bba-9e5b3bf85409@linaro.org>
On Mon, Nov 03, 2025 at 10:47:36AM +0100, Neil Armstrong wrote:
> Hi Mani,
>
> On 11/1/25 05:29, Manivannan Sadhasivam wrote:
> > Binding incorrectly specifies the 'DBI' region as 'ELBI'. DBI is a must
> > have region for DWC controllers as it has the Root Port and controller
> > specific registers, while ELBI has optional registers.
> >
> > Hence, fix the binding. Though this is an ABI break, this change is needed
> > to accurately describe the PCI memory map.
>
> Not fan of this ABI break, the current bindings should be marked as deprecated instead.
>
Fair enough. Will make it as deprecated.
- Mani
> >
> > Fixes: 7cd210391101 ("dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller")
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> > ---
> > Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml b/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml
> > index 79a21ba0f9fd62804ba95fe8a6cc3252cf652197..c8258ef4032834d87cf3160ffd1d93812801b62a 100644
> > --- a/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml
> > @@ -36,13 +36,13 @@ properties:
> > reg:
> > items:
> > - - description: External local bus interface registers
> > + - description: Data Bus Interface registers
> > - description: Meson designed configuration registers
> > - description: PCIe configuration space
> > reg-names:
> > items:
> > - - const: elbi
> > + - const: dbi
> > - const: cfg
> > - const: config
> > @@ -113,7 +113,7 @@ examples:
> > pcie: pcie@f9800000 {
> > compatible = "amlogic,axg-pcie", "snps,dw-pcie";
> > reg = <0xf9800000 0x400000>, <0xff646000 0x2000>, <0xf9f00000 0x100000>;
> > - reg-names = "elbi", "cfg", "config";
> > + reg-names = "dbi", "cfg", "config";
> > interrupts = <GIC_SPI 177 IRQ_TYPE_EDGE_RISING>;
> > clocks = <&pclk>, <&clk_port>, <&clk_phy>;
> > clock-names = "pclk", "port", "general";
> >
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2025-11-03 10:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 4:29 [PATCH RESEND 0/3] PCI: meson: Fix the parsing of DBI region Manivannan Sadhasivam
2025-11-01 4:29 ` [PATCH RESEND 1/3] dt-bindings: PCI: amlogic: Fix the register name of the " Manivannan Sadhasivam
2025-11-03 9:47 ` Neil Armstrong
2025-11-03 10:12 ` Manivannan Sadhasivam [this message]
2025-11-06 8:30 ` Krzysztof Kozlowski
2025-11-06 9:06 ` Manivannan Sadhasivam
2025-11-08 10:40 ` Manivannan Sadhasivam
2025-11-10 6:40 ` Neil Armstrong
2025-11-01 4:29 ` [PATCH RESEND 2/3] arm64: dts: amlogic: Fix the register name of the 'DBI' region Manivannan Sadhasivam
2025-11-03 9:47 ` Neil Armstrong
2025-11-01 4:29 ` [PATCH RESEND 3/3] PCI: meson: Fix parsing the DBI register region Manivannan Sadhasivam
2025-11-03 9:49 ` Neil Armstrong
2025-11-06 10:00 ` Neil Armstrong
2025-11-03 9:50 ` [PATCH RESEND 0/3] PCI: meson: Fix the parsing of DBI region Neil Armstrong
2025-11-03 10:14 ` Manivannan Sadhasivam
2025-11-10 6:56 ` (subset) " Manivannan Sadhasivam
2025-11-10 8:18 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rguwscxck7vel3hjdd2hlkypzdbwdvafdryxtz5benweduh4eg@sny4rr2nx5aq \
--to=mani@kernel.org \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hanjie.lin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=jingoohan1@gmail.com \
--cc=khilman@baylibre.com \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).