From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Alexandre Bailon <abailon@baylibre.com>,
rafael@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: rui.zhang@intel.com, lukasz.luba@arm.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] thermal: Add support of multiple sensors
Date: Tue, 30 Apr 2024 16:37:08 +0200 [thread overview]
Message-ID: <03fbaefa-de17-47f0-a48d-7b40e5df50f6@linaro.org> (raw)
In-Reply-To: <20240119110842.772606-1-abailon@baylibre.com>
Hi Alexandre,
On 19/01/2024 12:08, Alexandre Bailon wrote:
> Following this comment [1], this updates thermal_of to support multiple
> sensors.
>
> This has some limitations:
> - A sensor must have its own termal zone, even if it is also registered
> inside a thermal zone supporting multiple sensors.
> - Only support weighted average
Is it possible to elaborate why this feature is needed ?
The thermal framework is able to aggregate the cooling device requests,
so having multiple sensors aggregated or the cooling device requests is
from my point of view the same.
I can imagine one reason to do that is to group the sensors in order to
use the IPA because it won't work the setup mentioned above.
Is that the goal you want to achieve ?
> Changes in v2:
> - Rebased on 6.7
> - Seperated generic multi sensor and dt specfic code
> - Simplified the code
> - Drop min / max and only do weighted average (seems more adequate for IPA)
>
> [1]: https://patchwork.kernel.org/comment/24723927/
>
> Alexandre Bailon (3):
> dt-bindings: thermal: Restore the thermal-sensors property
> thermal: Add support of multi sensors to thermal_core
> thermal: Add support of multi sensors to thermal_of
>
> .../bindings/thermal/thermal-zones.yaml | 5 +-
> drivers/thermal/Makefile | 1 +
> drivers/thermal/thermal_core.h | 7 +
> drivers/thermal/thermal_multi.c | 178 ++++++++++++++++++
> drivers/thermal/thermal_of.c | 139 ++++++++++++++
> 5 files changed, 327 insertions(+), 3 deletions(-)
> create mode 100644 drivers/thermal/thermal_multi.c
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2024-04-30 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 11:08 [PATCH v2 0/3] thermal: Add support of multiple sensors Alexandre Bailon
2024-01-19 11:08 ` [PATCH v2 1/3] dt-bindings: thermal: Restore the thermal-sensors property Alexandre Bailon
2024-01-30 18:06 ` Rob Herring
2024-01-19 11:08 ` [PATCH v2 2/3] thermal: Add support of multi sensors to thermal_core Alexandre Bailon
2024-04-11 20:46 ` Pin-yen Lin
2024-01-19 11:08 ` [PATCH v2 3/3] thermal: Add support of multi sensors to thermal_of Alexandre Bailon
2024-04-12 20:42 ` Pin-yen Lin
2024-04-30 14:37 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03fbaefa-de17-47f0-a48d-7b40e5df50f6@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=abailon@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).