From: Odelu Kukatla <quic_okukatla@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
"Georgi Djakov" <djakov@kernel.org>,
Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
<cros-qcom-dts-watchers@chromium.org>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-hardening@vger.kernel.org>, <quic_rlaggysh@quicinc.com>,
<quic_mdtipton@quicinc.com>
Subject: Re: [PATCH v4 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support
Date: Wed, 27 Mar 2024 17:12:25 +0530 [thread overview]
Message-ID: <1e1fcedb-d001-4883-9046-58f3933ff185@quicinc.com> (raw)
In-Reply-To: <73e5a697-2eb4-45d3-84eb-60401ea10cc1@linaro.org>
On 3/27/2024 2:14 PM, Krzysztof Kozlowski wrote:
> On 26/03/2024 21:56, Konrad Dybcio wrote:
>> On 25.03.2024 7:16 PM, Odelu Kukatla wrote:
>>> It adds QoS support for QNOC device and includes support for
>>> configuring priority, priority forward disable, urgency forwarding.
>>> This helps in priortizing the traffic originating from different
>>> interconnect masters at NoC(Network On Chip).
>>>
>>> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>
>>> ---
>>
>> [...]
>>
>>>
>>> + if (desc->config) {
>>> + struct resource *res;
>>> + void __iomem *base;
>>> +
>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> + if (!res)
>>> + goto skip_qos_config;
>>> +
>>> + base = devm_ioremap_resource(dev, res);
>>
>> You were asked to substitute this call like 3 times already..
>>
>> devm_platform_get_and_ioremap_resource
>>
>> or even better, devm_platform_ioremap_resource
>
> Yeah, I wonder what else from my feedback got ignored :(
>
There was a misinterpretation of your comment from my side. Got it now, I will address this.
>
> Best regards,
> Krzysztof
>
Thanks,
Odelu
next prev parent reply other threads:[~2024-03-27 11:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 18:16 [PATCH v4 0/4] Add support for QoS configuration Odelu Kukatla
2024-03-25 18:16 ` [PATCH v4 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support Odelu Kukatla
2024-03-26 20:56 ` Konrad Dybcio
2024-03-27 8:44 ` Krzysztof Kozlowski
2024-03-27 11:42 ` Odelu Kukatla [this message]
2024-04-03 8:45 ` Odelu Kukatla
2024-04-13 19:31 ` Konrad Dybcio
2024-05-08 2:37 ` Mike Tipton
2024-05-28 14:52 ` Odelu Kukatla
2024-03-25 18:16 ` [PATCH v4 2/4] interconnect: qcom: sc7280: enable QoS programming Odelu Kukatla
2024-03-25 18:16 ` [PATCH v4 3/4] dt-bindings: interconnect: add clock property to enable QOS on SC7280 Odelu Kukatla
2024-03-26 7:30 ` Krzysztof Kozlowski
2024-03-27 11:35 ` Odelu Kukatla
2024-03-27 12:14 ` Krzysztof Kozlowski
2024-03-25 18:16 ` [PATCH v4 4/4] arm64: dts: qcom: sc7280: Add clocks for QOS configuration Odelu Kukatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e1fcedb-d001-4883-9046-58f3933ff185@quicinc.com \
--to=quic_okukatla@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).