From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Georgi Djakov <djakov@kernel.org>
Cc: robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com,
broonie@kernel.org, keescook@chromium.org, gustavoars@kernel.org,
henryc.chen@mediatek.com, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, kernel@collabora.com,
wenst@chromium.org, amergnat@baylibre.com
Subject: Re: [PATCH v5 7/7] interconnect: mediatek: Add MediaTek MT8183/8195 EMI Interconnect driver
Date: Mon, 6 May 2024 12:49:12 +0200 [thread overview]
Message-ID: <522a4bbb-af1b-418b-b00c-95657222160b@collabora.com> (raw)
In-Reply-To: <52335ded-43e7-4694-80bf-6ceee7d918d8@kernel.org>
Il 03/05/24 13:53, Georgi Djakov ha scritto:
> Hi Angelo,
>
> On 24.04.24 12:54, AngeloGioacchino Del Regno wrote:
>> Add an interconnect driver for the External Memory Interface (EMI),
>> voting for bus bandwidth over the Dynamic Voltage and Frequency Scaling
>> Resource Collector (DVFSRC).
>>
>> ICC provider ICC Nodes
>> ---- ----
>> --------- |CPU | |--- |VPU |
>> ----- | |----- ---- | ----
>> |DRAM |--|DRAM | ---- | ----
>> | |--|scheduler|----- |GPU | |--- |DISP|
>> | |--|(EMI) | ---- | ----
>> | |--| | ----- | ----
>> ----- | |----- |MMSYS|--|--- |VDEC|
>> --------- ----- | ----
>> /|\ | ----
>> |change DRAM freq |--- |VENC|
>> ---------- | ----
>> | DVFSR | |
>> | | | ----
>> ---------- |--- |IMG |
>> | ----
>> | ----
>> |--- |CAM |
>> ----
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> Thank you for working on this! It looks good to me.
> Do we have a plan how to merge all this?
>
Nothing (regulator, nor interconnect) will ever get enabled by Kconfig unless
the drivers/soc/mediatek patches are picked (or COMPILE_TEST!).... so I guess
we can just pick per-subsystem and call it a day :-)
As for the bindings, patch [3/7] *depends on* [1/7] and [2/7], but there is no
reverse dependency (so 1-2 can be picked, no warnings).
Otherwise I can pick all bindings, or.... whatever is easier for you :-)
Cheers,
Angelo
> Thanks,
> Georgi
>
>> ---
>> drivers/interconnect/Kconfig | 1 +
>> drivers/interconnect/Makefile | 1 +
>> drivers/interconnect/mediatek/Kconfig | 29 ++
>> drivers/interconnect/mediatek/Makefile | 5 +
>> drivers/interconnect/mediatek/icc-emi.c | 153 +++++++++++
>> drivers/interconnect/mediatek/icc-emi.h | 40 +++
>> drivers/interconnect/mediatek/mt8183.c | 143 ++++++++++
>> drivers/interconnect/mediatek/mt8195.c | 339 ++++++++++++++++++++++++
>> 8 files changed, 711 insertions(+)
>> create mode 100644 drivers/interconnect/mediatek/Kconfig
>> create mode 100644 drivers/interconnect/mediatek/Makefile
>> create mode 100644 drivers/interconnect/mediatek/icc-emi.c
>> create mode 100644 drivers/interconnect/mediatek/icc-emi.h
>> create mode 100644 drivers/interconnect/mediatek/mt8183.c
>> create mode 100644 drivers/interconnect/mediatek/mt8195.c
>
prev parent reply other threads:[~2024-05-06 10:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 9:54 [PATCH v5 0/7] MediaTek DVFSRC Bus Bandwidth and Regulator knobs AngeloGioacchino Del Regno
2024-04-24 9:54 ` [PATCH v5 1/7] dt-bindings: regulator: Add bindings for MediaTek DVFSRC Regulators AngeloGioacchino Del Regno
2024-04-24 9:54 ` [PATCH v5 2/7] dt-bindings: interconnect: Add MediaTek EMI Interconnect bindings AngeloGioacchino Del Regno
2024-04-24 9:54 ` [PATCH v5 3/7] dt-bindings: soc: mediatek: Add DVFSRC bindings for MT8183 and MT8195 AngeloGioacchino Del Regno
2024-04-24 9:54 ` [PATCH v5 4/7] soc: mediatek: Add MediaTek DVFS Resource Collector (DVFSRC) driver AngeloGioacchino Del Regno
2024-04-24 19:04 ` Nathan Chancellor
2024-04-29 8:08 ` AngeloGioacchino Del Regno
2024-04-29 14:13 ` Georgi Djakov
2024-04-24 9:54 ` [PATCH v5 5/7] regulator: Remove mtk-dvfsrc-regulator.c AngeloGioacchino Del Regno
2024-04-24 9:54 ` [PATCH v5 6/7] regulator: Add refactored mtk-dvfsrc-regulator driver AngeloGioacchino Del Regno
2024-04-24 10:35 ` Christophe JAILLET
2024-04-24 12:53 ` AngeloGioacchino Del Regno
2024-04-24 12:54 ` AngeloGioacchino Del Regno
2024-04-24 9:54 ` [PATCH v5 7/7] interconnect: mediatek: Add MediaTek MT8183/8195 EMI Interconnect driver AngeloGioacchino Del Regno
2024-05-03 11:53 ` Georgi Djakov
2024-05-06 10:49 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522a4bbb-af1b-418b-b00c-95657222160b@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=amergnat@baylibre.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=gustavoars@kernel.org \
--cc=henryc.chen@mediatek.com \
--cc=keescook@chromium.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).