From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuidle: ladder: fix ladder_do_selection() kernel-doc
Date: Tue, 7 May 2024 13:56:13 +0200 [thread overview]
Message-ID: <CAJZ5v0gj82ADfzP83QdMhmoyd8DZSMusmz1qAQP95iS+s5iqRw@mail.gmail.com> (raw)
In-Reply-To: <20240505-ladder_do_selection-kdoc-v1-1-fa0da92735dd@quicinc.com>
On Mon, May 6, 2024 at 2:42 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>
> make C=1 reports:
>
> warning: Function parameter or struct member 'dev' not described in 'ladder_do_selection'
>
> Document 'dev' for this function.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/cpuidle/governors/ladder.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpuidle/governors/ladder.c b/drivers/cpuidle/governors/ladder.c
> index 8e9058c4ea63..6617eb494a11 100644
> --- a/drivers/cpuidle/governors/ladder.c
> +++ b/drivers/cpuidle/governors/ladder.c
> @@ -44,6 +44,7 @@ static DEFINE_PER_CPU(struct ladder_device, ladder_devices);
>
> /**
> * ladder_do_selection - prepares private data for a state change
> + * @dev: the CPU
> * @ldev: the ladder device
> * @old_idx: the current state index
> * @new_idx: the new target state index
>
> ---
Applied as 6.10 material, thanks!
prev parent reply other threads:[~2024-05-07 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 0:42 [PATCH] cpuidle: ladder: fix ladder_do_selection() kernel-doc Jeff Johnson
2024-05-07 11:56 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0gj82ADfzP83QdMhmoyd8DZSMusmz1qAQP95iS+s5iqRw@mail.gmail.com \
--to=rafael@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).