From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] thermal: rcar_gen3: Update temperature approximation calculation
Date: Thu, 18 Apr 2024 11:34:36 +0200 [thread overview]
Message-ID: <CAMuHMdUJJXrd0++ep6RBikBCrBqh0oQvVV9_diR=VuDiEVmUzg@mail.gmail.com> (raw)
In-Reply-To: <20240327133013.3982199-3-niklas.soderlund+renesas@ragnatech.se>
On Wed, Mar 27, 2024 at 2:30 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> The initial driver used a formula to approximate the temperature and
> register values reversed engineered from an out-of-tree BSP driver. This
> was needed as the datasheet at the time did not contain any information
> on how to do this. Later Gen3 (Rev 2.30) and Gen4 (all) now contains
> this information.
>
> Update the approximation formula to use the datasheet's information
> instead of the reversed-engineered one.
>
> On an idle M3-N without fused calibration values for PTAT and THCODE the
> old formula reports,
>
> zone0: 52000
> zone1: 53000
> zone2: 52500
>
> While the new formula under the same circumstances reports,
>
> zone0: 52500
> zone1: 54000
> zone2: 54000
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> * Changes since v1
> - Fix spelling in commit message and code comments.
> - Improve calculation per Geert's suggestion of calculating directly in
> decidegrees. This allowed squashing patch 3/3/ in v1 into patch 2/2 in
> v2.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2024-04-18 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 13:30 [PATCH v2 0/2] thermal: rcar_gen3: Use temperature approximation from datasheet Niklas Söderlund
2024-03-27 13:30 ` [PATCH v2 1/2] thermal: rcar_gen3: Move Tj_T storage to shared private data Niklas Söderlund
2024-04-18 9:27 ` Geert Uytterhoeven
2024-05-14 10:18 ` [thermal: thermal/fixes] thermal/drivers/rcar_gen3: " thermal-bot for Niklas Söderlund
2024-03-27 13:30 ` [PATCH v2 2/2] thermal: rcar_gen3: Update temperature approximation calculation Niklas Söderlund
2024-04-18 9:34 ` Geert Uytterhoeven [this message]
2024-05-14 10:18 ` [thermal: thermal/fixes] thermal/drivers/rcar_gen3: " thermal-bot for Niklas Söderlund
2024-04-22 10:44 ` [PATCH v2 0/2] thermal: rcar_gen3: Use temperature approximation from datasheet Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUJJXrd0++ep6RBikBCrBqh0oQvVV9_diR=VuDiEVmUzg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).