From: Ulf Hansson <ulf.hansson@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Claudiu <claudiu.beznea@tuxon.dev>
Cc: mturquette@baylibre.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, magnus.damm@gmail.com,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v4 0/8] clk: renesas: rzg2l: Add support for power domains
Date: Thu, 25 Apr 2024 18:44:58 +0200 [thread overview]
Message-ID: <CAPDyKFrhPjuOR5iC+zy+SCJv5yoWU0fX8FfDbt9nrM6VRCjmNw@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdXHhsdOgTiDdqMwAMvb-m_VBqOcTRPURx_upc2AtmBTfA@mail.gmail.com>
On Wed, 24 Apr 2024 at 16:34, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Ulf,
>
> On Mon, Apr 22, 2024 at 12:54 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
> > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >
> > Series adds support for power domains on rzg2l driver.
> >
> > RZ/G2L kind of devices support a functionality called MSTOP (module
> > stop/standby). According to hardware manual the module could be switch
> > to standby after its clocks are disabled. The reverse order of operation
> > should be done when enabling a module (get the module out of standby,
> > enable its clocks etc).
> >
> > In [1] the MSTOP settings were implemented by adding code in driver
> > to attach the MSTOP state to the IP clocks. But it has been proposed
> > to implement it as power domain. The result is this series.
> >
> > The DT bindings were updated with power domain IDs (plain integers
> > that matches the DT with driver data structures). The current DT
> > bindings were updated with module IDs for the modules listed in tables
> > with name "Registers for Module Standby Mode" (see HW manual) exception
> > being RZ/G3S where, due to the power down functionality, the DDR,
> > TZCDDR, OTFDE_DDR were also added.
> >
> > Domain IDs were added to all SoC specific bindings.
> >
> > Thank you,
> > Claudiu Beznea
> >
> > Changes in v4:
> > - dropped the pwrdn functionality until it is better understanded
> > - dropped patch "clk: renesas: rzg2l-cpg: Add suspend/resume
> > support for power domains" from v3; this will be replaced
> > by propertly calling device_set_wakup_path() in serial console
> > driver
> > - instantiated the watchdog domain in r8a08g045 clock driver; this
> > allow applying r9a08g045 clock patch w/o affecting watchdog and later,
> > after all good with watchdog patches series at [2], only patch
> > "arm64: dts: renesas: r9a08g045: Update #power-domain-cells = <1>"
> > will need to be applied
>
> Are you happy with this series? I would like to queue patches 1-7 in
> renesas-clk for v6.10 (i.e. this week).
Yes, the series looks good to me! For the series, feel free to add:
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
prev parent reply other threads:[~2024-04-25 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 10:53 [PATCH v4 0/8] clk: renesas: rzg2l: Add support for power domains Claudiu
2024-04-22 10:53 ` [PATCH v4 1/8] dt-bindings: clock: r9a07g043-cpg: Add power domain IDs Claudiu
2024-04-22 10:53 ` [PATCH v4 2/8] dt-bindings: clock: r9a07g044-cpg: " Claudiu
2024-04-22 10:53 ` [PATCH v4 3/8] dt-bindings: clock: r9a07g054-cpg: " Claudiu
2024-04-22 10:53 ` [PATCH v4 4/8] dt-bindings: clock: r9a08g045-cpg: " Claudiu
2024-04-22 10:53 ` [PATCH v4 5/8] dt-bindings: clock: renesas,rzg2l-cpg: Update #power-domain-cells = <1> for RZ/G3S Claudiu
2024-04-22 10:53 ` [PATCH v4 6/8] clk: renesas: rzg2l: Extend power domain support Claudiu
2024-04-24 14:09 ` Geert Uytterhoeven
2024-04-22 10:53 ` [PATCH v4 7/8] clk: renesas: r9a08g045: Add support for power domains Claudiu
2024-04-24 14:10 ` Geert Uytterhoeven
2024-04-22 10:53 ` [PATCH v4 8/8] arm64: dts: renesas: r9a08g045: Update #power-domain-cells = <1> Claudiu
2024-04-24 14:33 ` [PATCH v4 0/8] clk: renesas: rzg2l: Add support for power domains Geert Uytterhoeven
2024-04-25 16:44 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrhPjuOR5iC+zy+SCJv5yoWU0fX8FfDbt9nrM6VRCjmNw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).