From: Cristian Marussi <cristian.marussi@arm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org,
morten.rasmussen@arm.com, dietmar.eggemann@arm.com,
lukasz.luba@arm.com, pierre.gondois@arm.com,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_mdtipton@quicinc.com,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V4 2/2] cpufreq: scmi: Register for limit change notifications
Date: Wed, 1 May 2024 09:26:13 +0100 [thread overview]
Message-ID: <ZjH8pWppKhayvFxx@pluto> (raw)
In-Reply-To: <ZjH7hWnKFcpQ-TXH@pluto>
On Wed, May 01, 2024 at 09:21:30AM +0100, Cristian Marussi wrote:
> On Thu, Mar 28, 2024 at 01:11:31PM +0530, Sibi Sankar wrote:
> > Register for limit change notifications if supported and use the throttled
> > frequency from the notification to apply HW pressure.
> >
>
> Hi Sibi,
>
> a bit late on this, sorry.
>
...forgot the tag :P
> Just a couple of nitpicks down below.
[snip]
> In general,
>
> LGTM.
>
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
next prev parent reply other threads:[~2024-05-01 8:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 7:41 [PATCH V4 0/2] firmware: arm_scmi: Register and handle limits change notification Sibi Sankar
2024-03-28 7:41 ` [PATCH V4 1/2] cpufreq: Export cpufreq_update_pressure Sibi Sankar
2024-03-28 7:41 ` [PATCH V4 2/2] cpufreq: scmi: Register for limit change notifications Sibi Sankar
2024-03-28 8:06 ` Lukasz Luba
2024-05-01 8:21 ` Cristian Marussi
2024-05-01 8:26 ` Cristian Marussi [this message]
2024-05-14 9:40 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjH8pWppKhayvFxx@pluto \
--to=cristian.marussi@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=pierre.gondois@arm.com \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).