From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Yangtao Li <frank.li@vivo.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuidle: kirkwood: Convert to platform remove callback returning void
Date: Mon, 29 Apr 2024 09:18:49 +0200 [thread overview]
Message-ID: <qwusw4lmmv7iff64l3qcdnnw762xlwag745dw5vhtfxspvsw2r@73ocsqlyhp5e> (raw)
In-Reply-To: <8fd3faf9-0179-425e-a68e-d0dc0a2d7da9@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2063 bytes --]
Hello Daniel,
On Tue, Apr 23, 2024 at 09:22:23AM +0200, Daniel Lezcano wrote:
> On 09/04/2024 18:32, Uwe Kleine-König wrote:
> > On Wed, Mar 06, 2024 at 10:33:06PM +0100, Uwe Kleine-König wrote:
> > > On Mon, Dec 04, 2023 at 12:55:17PM +0100, Uwe Kleine-König wrote:
> > > > On Wed, Jul 12, 2023 at 05:40:13PM +0800, Yangtao Li wrote:
> > > > > The .remove() callback for a platform driver returns an int which makes
> > > > > many driver authors wrongly assume it's possible to do error handling by
> > > > > returning an error code. However the value returned is (mostly) ignored
> > > > > and this typically results in resource leaks. To improve here there is a
> > > > > quest to make the remove callback return void. In the first step of this
> > > > > quest all drivers are converted to .remove_new() which already returns
> > > > > void.
> > > > >
> > > > > Trivially convert this driver from always returning zero in the remove
> > > > > callback to the void returning variant.
> > > > >
> > > > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > > Signed-off-by: Yangtao Li <frank.li@vivo.com>
> > > >
> > > > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > >
> > > > Can you pick this up?
> > >
> > > This patch isn't in next yet. Is this still on someone's radar for
> > > application? Would be great if this patch made it into the mainline
> > > during the upcomming merge window.
> >
> > It didn't made it into the merge window leading to 6.9-rc1. What are
> > the chances to get it into v6.10-rc1?
> >
> > I just checked, the patch was submitted when Linus's tree was just after
> > v6.5-rc1. So it already missed four merge windows without any maintainer
> > feedback :-\
>
> Sorry, it is applied now.
Is it expected that this patch didn't appear in next yet now that you
applied it?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-04-29 7:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 9:40 [PATCH] cpuidle: kirkwood: Convert to platform remove callback returning void Yangtao Li
2023-12-04 11:55 ` Uwe Kleine-König
2024-03-06 21:33 ` Uwe Kleine-König
2024-04-09 16:32 ` Uwe Kleine-König
2024-04-23 7:22 ` Daniel Lezcano
2024-04-29 7:18 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qwusw4lmmv7iff64l3qcdnnw762xlwag745dw5vhtfxspvsw2r@73ocsqlyhp5e \
--to=u.kleine-koenig@pengutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=frank.li@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).