From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Cc: linux-pwm@vger.kernel.org, Franklin S Cooper Jr <fcooper@ti.com>,
kernel@pengutronix.de
Subject: Re: [PATCH] pwm: tiecap: Drop .free() callback
Date: Fri, 30 Apr 2021 08:48:58 +0200 [thread overview]
Message-ID: <20210430064858.dwyitrocrvxk3lgm@pengutronix.de> (raw)
In-Reply-To: <20210429133218.66971-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
Hello,
On Thu, Apr 29, 2021 at 03:32:18PM +0200, Uwe Kleine-König wrote:
> ecap_pwm_free is only called when a consumer releases the PWM (using
> pwm_put() or pwm_free()). The consumer is expected to disable the PWM
> before doing that. It's not clear if a warning about that is justified, but
> if it is this is independent of the actual driver and can better be done in
> the core. Also if there is a good reason it's wrong to disable the hardware
> and so the call to pm_runtime_put_sync() should be dropped. Moreover there
> is no matching pwm_runtime_get call and so the runtime usage counter might
> become negative.
For the record: The two people from TI (Vaibhav Bedia
<vaibhav.bedia@ti.com>, Avinash Philip <avinashphilip@ti.com>) I
addressed with that patch (because they were involved previously with
this driver) didn't receive my mail. The addresses don't exist according
to TI's mail server. I dropped them from To: for this reply.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-04-30 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 13:32 [PATCH] pwm: tiecap: Drop .free() callback Uwe Kleine-König
2021-04-30 6:48 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430064858.dwyitrocrvxk3lgm@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=fcooper@ti.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).